mochajs / mocha
91%
main: 94%

LAST BUILD BRANCH: issue/5258
DEFAULT BRANCH: main
Repo Added
Files 56
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH issue/3009
branch: issue/3009
CHANGE BRANCH
x

5224

Pull #3631

travis-ci

web-flow 
execute test after "before each" hook asynchronously; closes #3009

This provides consistent, though not necessarily ideal, behavior when a
`Promise` is rejected within a "before" or "before each" hook and *not*
caught synchronously or within a `process.nextTick()` callback.

Previously, the `Promise` would be considered handled if it was rejected
in a "before each" hook and caught within the test, because the test
would be executed synchronously.  This is not the same case for a
"before" hook, which would consider the `Promise` unhandled.  Now, both
result in an unhandled exception warning from node.

An alternative implementation would be to execute tests within a
`process.nextTick()` callback (not sure what happens in a browser).
This would mean rejected `Promise`s in both cases would be considered
handled, because `process.nextTick()` would execute *before* the
microtask which then considers the `Promise` to be unhandled.

Mocha executes tests recursively, and needs to do so
asynchronously in order to avoid exceeding the maximum call stack.  As
per the Node.js documentation [here](https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/),
this is *not* a valid use case of `process.nextTick()`.

Yet another alternative implementation which may avoid a decision
entirely would be to execute tests using a generator.  This could only
be *simulated* in an environment such as IE11, and thus would
potentially result in inconsistent or undefined behavior when running
the same tests in different browsers (that being said, generators are
probably a Good Idea for Mocha to consume in the long run).
Pull Request #3631: execute test after "before each" hook asynchronously; closes #3009

917 of 1115 branches covered (82.24%)

2 of 2 new or added lines in 1 file covered. (100.0%)

2354 of 2599 relevant lines covered (90.57%)

520.17 hits per line

Relevant lines Covered
2599 RELEVANT LINES 2354 COVERED LINES
520.17 HITS PER LINE
Source Files on issue/3009

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
5224 issue/3009 execute test after "before each" hook asynchronously; closes #3009 This provides consistent, though not necessarily ideal, behavior when a `Promise` is rejected within a "before" or "before each" hook and *not* caught synchronously or within a `p... Pull #3631 web-flow travis-ci pending completion  
5223 issue/3009 execute test after "before each" hook asynchronously; closes #3009 This provides consistent, though not necessarily ideal, behavior when a `Promise` is rejected within a "before" or "before each" hook and *not* caught synchronously or within a `p... push boneskull travis-ci pending completion  
See All Builds (7074)