• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

mlibrary / keycard
100%
main: 100%

Build:
Build:
LAST BUILD BRANCH: dependabot/github_actions/coverallsapp/github-action-2.1.0
DEFAULT BRANCH: main
Repo Added 22 Feb 2018 12:54PM UTC
Files 42
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH AEIM-873-username-and-ip
branch: AEIM-873-username-and-ip
CHANGE BRANCH
x
Reset
  • AEIM-873-username-and-ip
  • 0.1.0
  • 0.1.1
  • 0.1.2
  • AEIM-1289-cleanup-identity
  • AEIM-1315-user-attributes
  • AEIM-1323-release-0.2
  • PFDR-106/api_key
  • PFDR-107/auth_token_with_spec_cleanup
  • aeim-1289-shib-attrs
  • bhock_comments
  • feature/aeim-872/agent-resolver
  • feature/aeim-872/qi
  • feature/aeim-932/integration
  • login-support
  • main
  • master
  • rails-integration
  • session_timestamp
  • spec_cleanup
  • sqlite
  • v0.2.0
  • v0.2.1
  • v0.2.2
  • v0.2.3
  • v0.2.4
  • v0.3.0
  • v0.3.1
  • v0.3.2
  • v0.3.3
  • v0.3.4

pending completion
38

push

travis-ci

botimer
AEIM-873 - Use wrapped requests instead of resolvers

This change clarifies responsibilities and addresses a small design
consideration of how the client IP is determined for use by the
InstitutionFinder. Rather than the previous design, which introduced a
concept of a "resolver" for the user/client attributes, there are now
different types of wrappers for the base (Rails or Rack) request. The
interface for a request wrapper is that it has two methods: `username`
and `client_ip`. Now, any additional collaborators that need to extract
attributes from the request will have these two properties available.

This change also accounts for multiple remote addresses and adds some
configuration information to the README.

142 of 142 new or added lines in 10 files covered. (100.0%)

468 of 468 relevant lines covered (100.0%)

3.93 hits per line

Relevant lines Covered
Build:
Build:
468 RELEVANT LINES 468 COVERED LINES
3.93 HITS PER LINE
Source Files on AEIM-873-username-and-ip
  • List 0
  • Changed 7
  • Source Changed 6
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
38 AEIM-873-username-and-ip AEIM-873 - Use wrapped requests instead of resolvers This change clarifies responsibilities and addresses a small design consideration of how the client IP is determined for use by the InstitutionFinder. Rather than the previous design, which int... push 29 May 2018 01:55PM UTC botimer travis-ci pending completion  
36 AEIM-873-username-and-ip AEIM-873 - Resolve client attributes when direct or proxied This introduces two new classes to resolve the request attributes of the client. They are called ClientResolver and ProxiedResolver for now, though those may not be the best names long-t... push 14 May 2018 05:46PM UTC botimer travis-ci pending completion  
34 AEIM-873-username-and-ip AEIM-873 - Resolve client attributes when direct or proxied This introduces two new classes to resolve the request attributes of the client. They are called ClientResolver and ProxiedResolver for now, though those may not be the best names long-t... push 14 May 2018 05:41PM UTC botimer travis-ci pending completion  
33 AEIM-873-username-and-ip Draft implementation of resolving based on direct or proxied connections push 30 Apr 2018 05:39PM UTC botimer travis-ci pending completion  
See All Builds (208)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc