mizosoft / methanol

91%

master: 90%

LAST BUILD ON BRANCH fix-missed-response

branch: fix-missed-response

CHANGE BRANCH

x

Reset

• fix-missed-response
• master
• http-caching
• fix-windows-diskstore-http-caching
• 35-strip-content-encoding
• 34-disable-decompression-for-HEADS
• v1.5.0
• v1.6.0
• spring-boot-fix
• jackson-polyformat
• fix-46
• v1.7.0
• redis
• investigate-ci-failure
• refactor-workflows
• jaxb-jakarta
• invalid-expires
• quarkus-native-test
• spi-touchups
• plain-native-tests
• local-properties
• multipartbodypublisher-formpart-test
• dependency-updates
• static-analysis
• unify-fallback-executor
• dead-code
• cache-touch-ups
• save-request-copy
• set-headers
• fail-on-duplicate-directives
• pass_emit_failures_downstream
• headers-accumulator-spec
• adapter-codec-touchups
• test-timeout-and-interruption
• test-subscriber-trylock
• response-publisher
• redis-store-touch-ups
• fix-method-copy
• name-fallbackexecutor-thread
• retain-status-header
• adapter-improvements
• kotlin-extensions
• crp-cwp-touchups
• bcs-touch-ups
• allow-creating-websockets
• test-timeout-touch-ups
• proper-tostring

Build # #236

Build Type

Pull #69

github

Committed by mizosoft

Commit Message

Fix missed response for HttpResponsePublisher

Because `onResponse(response)` decrements `ongoing` prematurely (before
submitting the response and potentially completing downstream), the last
response passed might be missed when a race happens with
`onInitialResponseBodyCompletion()`. Consider this scenario:

 - `onResponse` & `onInitialResponseBodyCompletion` interleave.
 - `onResponse` acquires the lock first, and decrements `ongoing`. It
   won't perceive initial body completion, so it won't want to complete
   downstream.
 - `onInitialResponseBodyCompletion` acquires the lock later, and perceives
   no ongoing responses, so it proceeds with the intent to complete downstream.
 - `onInitialResponseBodyCompletion` continues, and calls `complete()`, which
   pushes the sentinel to the queue.
 - `onResponse` continues to `submit(response)`, but the response is submitted
   after the sentinel and is hence ignored.

The fix is to not prematurely decrement `ongoing` when the last response is received,
but do so after the response is submitted. This way, `onInitialResponseBodyCompletion`
never perceives a completed stream that is not **really** completed.

Pull Request Pull Request #69: Fix missed response for HttpResponsePublisher

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

6682 of 7318 relevant lines covered (91.31%)

0.91 hits per line