mithro / python-datetime-tz

89%

master: 89%

LAST BUILD ON BRANCH remove-genshi

branch: remove-genshi

CHANGE BRANCH

x

Reset

• remove-genshi
• all-pytz-check
• en-3.5
• lint-cleanup
• master
• py38
• sudo-false
• travis-fix
• v0.3
• v0.5
• v0.5.1
• v0.5.2
• v0.5.4

Build # 117

Build Type

push

travis-ci-com

Committed by micolous

Commit Message

Migrate from Genshi to defusedxml in update_win32tz_map.py:

* Add `defusedxml` to `install_requires`.  Genshi was never listed, although
  it was only a requirement for building sdist.

* Removed support for copying comments from CLDR XML.  This would be
  difficult without a DOM parser, but the source file contains a local DTD
  reference which is banned in defusedxml.

* Switch `create_win32tz_map` to a mostly-functional processing model, by
  `yield`ing earlier, instead of building complete dicts and `yield`ing
  after-the-fact.  This causes output to be no longer sorted alphabetically.

* Move special handling of `territory=001` into `create_win32tz_map`.

Tested that generated content is identical, although the ordering will
differ.

Google-internal bug: 160436149

Run Details

531 of 597 relevant lines covered (88.94%)

3.53 hits per line