ministryofjustice / bootstrap-cfn

53%

master: 58%

LAST BUILD ON BRANCH fix_certificate_updating_on_live_elbs

branch: fix_certificate_updating_on_live_elbs

CHANGE BRANCH

x

Reset

• fix_certificate_updating_on_live_elbs
• test_coverage
• master
• enable_cert_updates
• feature/sg-refs
• salt_doc
• refactor-fab_tasks
• use-boto-config
• feature/salt-pillar
• feature/elb-sg
• v0.2.0
• fix/rsync-task
• fix/custom_s3_policy
• update-config
• v0.2.1
• abort_on_rollback
• issue-56-elb-no-longer-optional
• issue/56-elb-no-longer-optional
• custom_elb_sg_tests
• dockerfile_for_local_execution
• management_subnets
• sane_defaults
• show_events
• iam-cross-account
• issue/block-devices-mandatory
• custom-vpc
• feature/extend-template
• ci-test
• v0.2.2
• rename-moj-salt-script
• travis-test
• pep8-on-hunks
• rds/storage_encrypted
• l-
• fix_internal_elb
• readme-fixup
• bug/storage-type
• v0.3.1
• elb-iam-role
• feature/elb-healthcheck
• fix_deprecated_delete_certificate_force
• build_from_snapshot
• v0.3.3
• v0.4.0
• fix-pypi-dist
• v0.4.1
• handle-config-file-not-found
• add_docstrings_to_fab_tasks
• troposphere
• v0.5.0
• stack-name-tagging
• v0.5.1
• fix_certificate_deletion
• v0.5.2
• fix-elb-policy
• fix-error-message
• delete-dangling-ssl-certs
• test_flag
• troposphere2
• tag_all_stack_resources
• deprecated_config_env_tag
• fix/s3-perms
• v0.5.3
• self-referential-sg
• dns-delete
• add-elb-tasks
• consistent-imports
• hostname-template
• upgrade_to_boto3_wip
• automatic_resource_naming
• add-elb-dns-task
• feature/autoscale-tags
• v0.5.4
• automatic_resource_naming_elb
• add-list-elb-dns
• custom-config
• automatic_resource_naming_rds
• userdata-change
• v0.5.5
• v0.5.6
• automatic_resource_naming_elb_simple
• cfn_delete-hooks
• fix_sudo_hostname_error
• v0.5.7
• new-ami
• sql-server-db-name
• v0.5.8
• v0.5.9
• fix_crossaccount_iam
• deletion-prompt
• tag-product-name
• add_elasticache_redis_only
• permit-tagging-from-instances
• v0.5.10
• fix-exception-keyerror
• multiple_s3_buckets
• feature-maintenance-mode
• v0.5.11
• feature_enable_ec2_volume_types
• feature_enable_ec2_volume_types_updated
• v0.6.0
• feature_specify_policies_for_elbs
• 0.6.1
• v0.6.2
• add_vpc_peering
• v0.6.3
• add_dynamic_vpc_addressing
• add_vpc_peering_advanced
• read-replica
• remove_fallback_on_missing_route53_stack_name
• add_get_basic_config
• fix_autoscale_paging
• v0.7.0
• v0.7.1
• fix_get_resource_type_for_back_compatibility
• v0.7.2
• restore_previous_get_resource_type_for_back_compatibility
• v0.7.3
• separate_out_get_set_stack_name
• v0.7.4
• v0.7.5
• unbreak-update-certs
• v0.7.6
• fix_dont_pass_bulk_text_as_max_retries_value
• add_windows_support
• foosave
• v0.7.7
• add_upgrade_to_cloud_init
• fix_missing_vpc_import
• check_asg_health_check_is_done
• add_name_tag_to_instances
• add_cycle_instances_task
• add_simple_countdown_for_long_waits
• set_boto3_session_to_use_aws_profile
• override_ami
• release_0.8.0
• release_0.8.2
• v0.8.2
• allow-different-aws-for-route53
• dont_set_name_tag_if_manually_set
• v0.8.3
• make_update_certs_more_tolerant
• v0.8.4
• mssql-sg
• v0.8.5
• add-default-region-for-boto3
• add-dry-run-to-maintenance
• fix-exit-maintenance-boto3
• update_ubuntu_ami_to_20160509
• v0.9.0
• default_rds_encryption_to_true
• set_rds_defaults
• add_random_number_generator_to_rds
• v0.10.0
• add_dependson_requirements
• fils-dependency-implementation
• create_multiple_stacks
• get_stack_list
• fix-readd-loadbalancer-permissions
• v0.11.0
• fix_data_files_build
• v0.11.1
• multiple_stacks_unittest
• side_multiple_tasks
• update_flake8_import_order_version
• new_version
• cfn_create_fail_cleanup
• add_get_stack_list
• rename_s3_bucket_output_to_be_consistent
• add_keyname_to_fab_parameters
• add_elastic_ip_pool
• update-readme-format
• update_enter_maintenance_update_a_dns_record
• update_deployarn_if_active_stack_changes
• add_version_tag
• update_default_rds_version
• markup_fix
• disable-pp-cfn
• get-elb-helpers
• delete-cert-cfn-delete
• remove_subnet_hardwiring
• disable_encryption_on_staging_rds
• v1.3.0rc1
• drop_awsencode
• update_get_stack_list_algorithm
• add_stack_check
• add_acm_support
• v1.3.0
• v1.4.0
• fix-set-active-stack-on-internal-lb
• fix_cfn_delete_on_wsproxy
• ssl-acm-fix-1
• fix_acm_alternative_names_tests
• v1.4.1
• dnstag_fix
• lifecycle-non-static-buckets
• unblock-tail-on-delete
• add-tests
• make-update-record-backwards-compatible
• unblock-tests-remove-pdb
• alb-support-v1
• support_alternative_domain_name_validation_options
• v1.5.3
• elasticsearch

Build # 1198

Build Type

push

travis-ci

Committed by niallcreech

Commit Message

AWS wont let us update out certs when ELBs are using them so to allow
for dynamic updates we follow the logic,
- go through all the ELBs listeners looking for https connections
- save the current cert ssl name
- replace the cert ssl with a uniquesly timestamped
- optionally delete the previous ssl

Note that AWS can take time to propogate changes, so even when they
appear to be done, we need to apply retry loops and delays to make
sure they have been applied across all AWS infrastructure and not
exiting prematurely.

Features:
* Allow dynamically updating SSL certs robustly
* Drop ssl data argument from delete_certificate tests

Fixes:
* Cloudformation get resource now returns a dict

Run Details

66 of 66 new or added lines in 4 files covered. (100.0%)

696 of 1323 relevant lines covered (52.61%)

0.53 hits per line