mbland / go-script-bash

95%

master: 95%

LAST BUILD ON BRANCH fix-coverage-kcov-v35

branch: fix-coverage-kcov-v35

CHANGE BRANCH

x

Reset

• fix-coverage-kcov-v35
• master
• go-template-download
• skip-template-test
• v1.6.0
• null
• create-fwd-script-#186
• bats-helpers
• stub-hash-reset
• forwarding-script
• run-script-helpers
• cl-assertions-#181
• skip-if-none-present-#186
• platform-#184
• native-path-#186-#187
• platform-freebsd
• walk-#184
• fileutil-module-#184
• diff-lib
• path-lib
• copy-#184
• fix-fileutil-create-dirs-msys2
• mirror-dir-#186
• tarball-#186
• cla-#214
• cla-#217
• appveyor
• issue-template
• v1.7.0
• close-bats-fd-3
• bats-v1.0.1

Build # 819

Build Type

push

travis-ci

Committed by mbland

Commit Message

lib/kcov-ubuntu: Use kcov v35 to fix test coverage

I noticed during the build for #227 that test coverage dropped
precipitously for no apparent reason:

  https://coveralls.io/builds/14508796

The coverage dropped because SimonKagstrom/kcov@0dd22bd added the
ability for kcov to automatically discover all scripts residing in the
same directory of the script under test. In this case, it unfortunately
discovered all the scripts in ./git and tests/kcov, as well as various
*.md and *.yml files that happened to have "bash" in the first line
regardless of the presence of a #!.

The interim fix for this was to add the --bash-dont-parse-binary-dir and
to update the tests accordingly.

Also, since a bit of time elapsed since I returned to the problem, I
realized the latest tip of kcov's master branch exhibited the hanging bug I
helped squash in SimonKagstrom/kcov#211. The bug was reintroduced in
SimonKagstrom/kcov@ad17136, which tried to fix a bug reported in
SimonKagstrom/kcov#248 whereby kcov would hang on output that didn't
contain newlines.

SimonKagstrom/kcov#249 attempted to resolve the bug, but didn't quite
work and was abandoned. I may take a stab at fixing it one day, but in
the meanwhile, kcov v35 with --bash-dont-parse-binary-dir works to get
this project's test coverage back in shape.

Run Details

3228 of 3397 relevant lines covered (95.03%)

250.01 hits per line