mattbox / onebot

67%

Build Type

push

github

Committed by web-flow

Commit Message

fix: convert user settings to async and centralize serialization (#241)

* fix: convert user settings to async and centralize serialization

Convert User.set_setting and User.set_settings to async methods to prevent
race conditions and allow proper error handling. Centralize JSON
serialization in the User class and remove redundant dumps in ACLPlugin.
Remove redundant (object) inheritance for Python 3 modernization.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(tests): correct regression tests for async set_setting

- test_remove_acl: expect JSON string '[]' since set_setting serializes
  to JSON for Redis compatibility
- test_setuser: use AsyncMock for set_setting, dispatch inside wrap()
  with one_moment() (freeze_time tick=True) so the async command handler
  actually runs before asserting

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ruff format

* fix(acl): restore json.dumps for --by-id db.set path

The --by-id path bypasses user.set_setting and writes directly to
bot.db. Must serialize to JSON for Redis compatibility, same as the
user.set_setting path.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: remove unused asyncio import

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Coverage Stats

21 of 24 new or added lines in 6 files covered. (87.5%)

48 existing lines in 3 files now uncovered.

950 of 1410 relevant lines covered (67.38%)

3.36 hits per line