marvinpinto / charlesbot

100%

master: 100%

LAST BUILD ON BRANCH timeout-error

branch: timeout-error

CHANGE BRANCH

x

Reset

• timeout-error
• bumpversion-auto-updates
• consolidate-avatars
• disjoint-ca-projects
• help-ping-plugins
• master
• ping-plugin
• slack-singleton
• sphinx-documentation
• split-plugin-architecture
• strip-broadcast-message-plugin
• strip-jira-plugin
• strip-pagerduty-plugin
• update-documentation
• v0.10.0
• v0.5.0
• v0.6.0
• v0.7.0
• v0.8.0
• v0.9.0

Build # 128

Build Type

push

travis-ci

Committed by marvinpinto

Commit Message

Reconnect to the Slack websocket on disconnection

This ended up being a nasty bug that was hard to reproduce. The error
logs looked something like:

2015-09-24 07:58:02,432: ERROR [asyncio:1008] Task exception was never retrieved
future: <Task finished coro=<produce() done, defined at /src/env/lib/python3.4/site-packages/charlesbot/robot.py:28> exception=TimeoutError(110, 'Connection timed out')>
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncio/tasks.py", line 238, in _step
    result = next(coro)
  File "/src/env/lib/python3.4/site-packages/charlesbot/robot.py", line 31, in produce
    yield from self.route_message_to_plugin()
  File "/src/env/lib/python3.4/site-packages/charlesbot/robot.py", line 36, in route_message_to_plugin
    messages = self.sc.rtm_read()
  File "/src/env/lib/python3.4/site-packages/slackclient/_client.py", line 27, in rtm_read
    json_data = self.server.websocket_safe_read()
  File "/src/env/lib/python3.4/site-packages/slackclient/_server.py", line 109, in websocket_safe_read
    data += "{}\n".format(self.websocket.recv())
  File "/src/env/lib/python3.4/site-packages/websocket/_core.py", line 348, in recv
    opcode, data = self.recv_data()
  File "/src/env/lib/python3.4/site-packages/websocket/_core.py", line 365, in recv_data
    opcode, frame = self.recv_data_frame(control_frame)
  File "/src/env/lib/python3.4/site-packages/websocket/_core.py", line 378, in recv_data_frame
    frame = self.recv_frame()
  File "/src/env/lib/python3.4/site-packages/websocket/_core.py", line 410, in recv_frame
    return self.frame_buffer.recv_frame()
  File "/src/env/lib/python3.4/site-packages/websocket/_abnf.py", line 300, in recv_frame
    self.recv_header()
  File "/src/env/lib/python3.4/site-packages/websocket/_abnf.py", line 249, in recv_header
    header = self.recv_strict(2)
  File "/src/env/lib/python3.4/site-packages/websocket/_abnf.py", line 334, in recv_strict
    bytes = self.recv(min(16384, shortage))
  F... (continued)

Run Details

668 of 668 relevant lines covered (100.0%)

1.0 hits per line