markdown-it / markdown-it

100%

master: 100%

LAST BUILD ON BRANCH issue76

branch: issue76

CHANGE BRANCH

x

Reset

• issue76
• 0.17
• 0.19
• 0.21
• 0.24
• 0.28
• 0.30
• 10.0.0
• 11.0.0
• 11.0.1
• 12.0.0
• 12.0.1
• 12.0.2
• 3.0.0
• 3.0.1
• 3.0.2
• 3.0.3
• 3.0.4
• 3.0.5
• 3.0.7
• 3.1.0
• 4.0
• 4.0.0
• 4.0.1
• 4.0.2
• 4.0.3
• 4.1.0
• 4.1.1
• 4.1.2
• 4.2.0
• 4.2.1
• 4.2.2
• 4.3.0
• 4.4.0
• 5.0.0
• 5.0.1
• 5.0.2
• 5.0.3
• 5.1.0
• 6.0.0
• 6.0.1
• 6.0.2
• 6.0.3
• 6.0.4
• 6.0.5
• 6.1.0
• 6.1.1
• 696
• 7.0.0
• 7.0.1
• 720
• 724
• 772
• 8.0.0
• 8.0.1
• 8.1.0
• 8.2.0
• 8.2.1
• 8.2.2
• 8.3.0
• 8.3.1
• 8.3.2
• 8.4.0
• 8.4.1
• 8.4.2
• 830
• 9.0.0
• 9.0.1
• 9.1.0
• abbr
• actions
• autolink
• autolink_replacements
• babelmark
• backtick
• bq_indent
• build
• changelog
• cmark
• cmark29
• comment
• compiler
• cov
• cov2
• coverage
• crlf-fix
• delims
• demo
• dependabot/github_actions/actions/checkout-3
• dependabot/github_actions/actions/setup-node-2.5.1
• dependabot/github_actions/actions/setup-node-3
• dependabot/github_actions/actions/setup-node-4
• dependabot/github_actions/coverallsapp/github-action-1.1.3
• dependabot/npm_and_yarn/entities-3.0.1
• dependabot/npm_and_yarn/mdurl-2.0.0
• dev
• dev-2
• em
• emph
• emph3
• emph4
• emphasis
• emphasis_perf
• eol
• es6
• escapes
• exit
• fences
• fix-896
• fix-bq
• fix-quote-term
• fixes
• fixes2
• helpers
• hl
• hl2
• levels
• lheading
• markup
• master
• mdurl
• migration
• mn
• mn2
• mono
• next
• normalize2
• ol
• p
• path
• pathological
• perf
• proto
• punycode
• push
• quotes
• ref-draft
• refactors
• references
• refs
• refs/tags/12.0.3
• refs/tags/12.0.4
• refs/tags/12.0.5
• refs/tags/12.0.6
• refs/tags/12.1.0
• refs/tags/12.2.0
• refs/tags/12.3.0
• refs/tags/12.3.1
• refs/tags/12.3.2
• refs/tags/13.0.0
• refs/tags/13.0.1
• refs/tags/13.0.2
• refs/tags/14.0.0
• refs/tags/14.1.0
• scandelims
• sharetoken
• skipToken
• skiplastlf
• smartq
• smartquotes
• sp
• spec
• ss
• table
• table-fix
• table-tabs
• tables
• tables3
• tabs
• td2
• test
• tests
• title
• tokenclass
• tropen
• typographer
• uglify
• unescapeAll
• update
• updates
• urllimit
• workaround
• yemph

Build # 327

Build Type

push

travis-ci

Committed by rlidwka

Commit Message

Fix undefined variable check in smartquotes

We had three bugs cancelling each other out:

 1. `token.text` should be `token.content`. We never had `token.text`
    here, so it must've been a typo.

 2. `.test()` condition should be negated, because we need to skip
    tokens without quotes, not with them.

 3. the entire `if` statement is in the wrong place messing with
    level calculations (see attached test)

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

1902 of 1902 relevant lines covered (100.0%)

334.41 hits per line