marionettejs / backbone.marionette

100%

master: 100%

LAST BUILD ON BRANCH sjs/object-controller

branch: sjs/object-controller

CHANGE BRANCH

x

Reset

• sjs/object-controller
• 2.4.2
• 2.4.3
• 2.4.4
• MeoMix-patch-3
• broken-link-doc
• bugfix
• bye-app-regions
• bye-tojson
• coveralls
• denar90-nightly-build-test
• denar90-nightly-build-test-2
• dependabot/npm_and_yarn/browserslist-4.16.6
• dependabot/npm_and_yarn/handlebars-4.7.6
• dependabot/npm_and_yarn/handlebars-4.7.7
• dependabot/npm_and_yarn/hosted-git-info-2.8.9
• dependabot/npm_and_yarn/ini-1.3.7
• dependabot/npm_and_yarn/lodash-4.17.19
• dependabot/npm_and_yarn/lodash-4.17.21
• dependabot/npm_and_yarn/underscore-1.12.1
• dependabot/npm_and_yarn/y18n-3.2.2
• deprecate-controller
• deprecate-refresh
• drop-matrix
• empty-options-docs
• fix-3414
• fix-ie11
• get-parentlayout
• hi-mn
• issue-3421
• jmeas-fix
• jmeas-patch-1
• layout-view
• lodash4-support
• major
• master
• merge-options
• metal-fix
• minor
• minus-switch
• next
• patch
• paulfalgout-patch-1
• paulfalgout-patch-2
• pjf/collectionview-iso
• pjf/grandchild-attach
• pjf/refactor-trigger-method
• pjf/region-next
• pjf/try-v3
• pr/1874
• pr/1987
• prev
• region-next-build
• region-ui-hash
• rename-view
• sans-bindall
• sauce-ports
• sjs/1694-fix
• sjs/1874
• sjs/1902
• sjs/SerializeModel
• sjs/add-defer-doc
• sjs/add-doc-links
• sjs/add-region-swap-out
• sjs/add-templatecache-options
• sjs/add-underscore-1-7
• sjs/addOptionProxyToApplication
• sjs/auto-collection
• sjs/behavior-collision-fix
• sjs/behavior-error
• sjs/bump-jquery-dep
• sjs/bump-underscore
• sjs/contributing
• sjs/doc-update
• sjs/drop-old-backbone
• sjs/fix-1714
• sjs/fix-broken-collection-docs
• sjs/fix-broken-docs
• sjs/fix-child-events-naming
• sjs/fix-coverage-metrics
• sjs/fix-ignores
• sjs/fix-is-empty
• sjs/fix-layout-doc-header
• sjs/fix-region-bug
• sjs/fix-regionMananger-extend
• sjs/fix-unused-listener
• sjs/kill-calbacks
• sjs/lock-dev-deps
• sjs/lodash
• sjs/main-doc
• sjs/move-readme
• sjs/on-remove-child-bug
• sjs/on-render-collection-bug
• sjs/readme-fixes
• sjs/region-attach-bug-fix
• sjs/region-events
• sjs/region-manager
• sjs/region-prevent-destroy
• sjs/region-swap-bug
• sjs/region-undefined-bug
• sjs/remove-region-event-bug
• sjs/render-collection-doc
• sjs/revert-dep
• sjs/revert-doc-change
• sjs/simplify-behaviors-wrap
• sjs/swap-out-bug
• sjs/template-error
• sjs/template-less-docs
• sjs/trigger-call-options
• sjs/validate-yaml
• sjs/warn-collection
• sjs/wip
• sjs/wreqr-proxy
• sjs/wreqr-update
• tooling
• travis-fix
• travis-simp
• travis/lod3.1
• trigger-www
• untagged-b73dca4511593e111421
• update-title
• v2.0.0
• v2.0.0-pre.x
• v2.0.1
• v2.0.2
• v2.0.3
• v2.1
• v2.1.0-pre
• v2.2
• v2.2.0
• v2.2.0-pre
• v2.2.0-pre.2
• v2.2.1
• v2.3.0
• v2.3.1
• v2.3.2
• v2.4
• v2.4.0
• v2.4.1
• v2.4.2
• v2.4.3
• v2.4.4
• v2.4.5
• v2.4.6
• v2.4.7
• v2.5.6
• v3-1-docs
• v3.0.0
• v3.0.0-pre.3
• v3.0.0-pre.4
• v3.0.0-pre.5
• v3.0.0-rc
• v3.1-release
• v3.1.0
• v3.2.0
• v3.3.0
• v3.3.1
• v3.4.0
• v3.4.1
• v3.4.2
• v3.4.3
• v3.4.4
• v3.5
• v3.5.0
• v3.5.1
• v4-1-bump
• v4-alpha
• v4-beta
• v4.0.0
• v4.0.0-alpha.1
• v4.0.0-beta.1
• v4.1.0
• v4.1.1
• v4.1.2
• v4.1.3
• view-events

Update controller to be inline with Object.

Since they were around 95% the same, I have gone ahead and cut down on
duplicate code and simplified them.

There was one test change needed, since the controller options used to default to an
empty object, the old test asserting that it was invoked with an empty
object is no longer valid.

This should not be breaking and so I think it we are fine to go ahead with this.