m-lab / pusher
99%
main: 99%

LAST BUILD BRANCH: v1.20.5
DEFAULT BRANCH: main
Repo Added
Files 9
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

coverage: 98.919% (-1.1%) from 100.0%
460

push

travis-ci-com

web-flow 
Removes old, empty directories from datatype root directories (#99)

* Removes old, empty directories

Pusher did not remove old directories. Every extant directory creates an
inotify watch in pusher. Over time and/or for experiments (e.g., wehe)
that create a large amount of directories, this can create a very large
number of useless watches, which eat up memory, and eventually may run
up against fs.inotify.max_user_watches, causing other containers on the
system to fail.

This commit also fixes an apparent variable name bug in which the value
for maxFileAge was put into a variable named minFileAge.

* Removes old, empty directories when walking dir

Previously, directories were not touched. On long-running containers
directories would begin to pile up causing a large amount of useless
pusher inotify directories watches.

* Uses Go v1.18 to build Docker image, and Alpine 3.15

* Updates Go modules

* Reverts prometheus/client_golang to v1.11.0

I was running into this with newer versions:

https://github.com/prometheus/prometheus/issues/10574

* Updates Travis to use Go v1.18

* Reverts Go to v1.17 (from v1.18)

The travis build was failing with something like this:

https://github.com/mattn/goveralls/issues/207

... and the Docker build was failing with this error:

Step 8/10 : COPY --from=build /go/bin/pusher /
COPY failed: stat go/bin/pusher: file does not exist

* Adds a clarifying comment about removing dirs

* Simplifies dir removal logic, removes branching

36 of 36 new or added lines in 1 file covered. (100.0%)

549 of 555 relevant lines covered (98.92%)

12497.99 hits per line

Relevant lines Covered
555 RELEVANT LINES 549 COVERED LINES
12497.99 HITS PER LINE
Source Files on master
Detailed source file information is not available for this build.

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
460 master Removes old, empty directories from datatype root directories (#99) * Removes old, empty directories Pusher did not remove old directories. Every extant directory creates an inotify watch in pusher. Over time and/or for experiments (e.g., wehe) ... push web-flow travis-ci-com
98.92
449 master Seeds math/rand (#98) * Seeds math/rand For background on why this is necessary see: https://github.com/m-lab/dev-tracker/issues/689 * Changes 'unexpected' to 'unintended' in comment push web-flow travis-ci-com
100.0
443 master Use complete mode for creating dirs (#97) push web-flow travis-ci-com
100.0
435 master Update go mod and add note in uploader.Upload (#94) push web-flow travis-ci
100.0
432 master Uses new package m-lab/go/host to parse nodeName (#92) * Uses new m-lab/go/host package to parse nodeName instead of writing custom regexps. * Updates go.mod and go.sum (the result of running 'go mod tidy'). * Removes now-unused import regexp, ... push web-flow travis-ci
100.0
428 master just checking if build still ok api web-flow travis-ci
100.0
426 master Merge pull request #91 from m-lab/sandbox-kinkade Slightly looser regexp matching on nodeName push web-flow travis-ci
100.0
422 master Adds "dirty" as a suffix when building pusher on a dirty repo. (#90) push web-flow travis-ci
100.0
418 master Adds a timeout to the GCS upload process. (#89) push web-flow travis-ci
100.0
414 master Limit the inter-cleanup time to a maxmimum (#86) Should make alerts more stable. push web-flow travis-ci
100.0
See All Builds (443)