m-lab / locate

96%

main: 92%

LAST BUILD ON BRANCH v0.17.8

branch: v0.17.8

CHANGE BRANCH

x

Reset

• v0.17.8
• main
• sandbox-cristinaleon-fix-hostname
• sandbox-cristinaleon-fix-label
• sandbox-cristinaleon-fix-prom-hostname
• sandbox-kinkade
• sandbox-kinkade-siteinfo
• sandbox-roberto-cloudbuild
• sandbox-roberto-cmsketch
• sandbox-roberto-connlimit
• sandbox-roberto-eeflag
• sandbox-roberto-fix-rl
• sandbox-roberto-heartbeat-jwt
• sandbox-roberto-jwt
• sandbox-roberto-metrics
• sandbox-roberto-no-promote
• sandbox-roberto-pass-qs-params
• sandbox-roberto-ratelimit
• sandbox-roberto-ratelimit-block
• sandbox-roberto-statistical-pt
• sandbox-roberto-update-cloudbuild
• sandbox-roberto-update-rl
• sandbox-soltesz-docs-parameters
• sandbox-soltesz-ns-replace
• sandbox-soltesz-testdeploy
• v0.15.6
• v0.15.7
• v0.15.8
• v0.16.0
• v0.17.0
• v0.17.1
• v0.17.2
• v0.17.3
• v0.17.4
• v0.17.5
• v0.17.6
• v0.17.7
• v0.18.0

Build # 1591

Build Type

push

travis-pro

Committed by web-flow

Commit Message

Avoids a nil pointer dereference error in Geo() (#227)

* Avoids a nil pointer dereference error in Geo()

There was a case in staging where Locate was returning this for a host:

  "neubot-mlab4-syd04.mlab-staging.measurement-lab.org": {
    "Health": null,
    "Registration": null,
    "Prometheus": {
      "Health": false
    }
  },

... this was causing a panic in Locate. This commit avoids this, and adds a new
unit test to be sure it working as intended.

* Fixes a few typos in a comment in Geo()

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

2022 of 2097 relevant lines covered (96.42%)

1.07 hits per line