loot / loot-condition-interpreter

90%

master: 91%

LAST BUILD ON BRANCH avoid-literals-in-paths

branch: avoid-literals-in-paths

CHANGE BRANCH

x

Reset

• avoid-literals-in-paths
• 2.0.0
• 2.0.1
• 2.1.0
• 2.1.1
• 2.4.0
• 3.0.0
• 3.1.0
• 4.0.0
• 4.0.1
• 4.0.2
• 5.0.0
• 5.1.0
• 5.2.0
• 5.3.0
• 5.3.1
• 5.3.2
• 5.3.3
• add-cargo-lock
• add-readable
• add-trait-derives
• allow-line-breaks
• better-version-comparison
• cargo-vet
• check-hash
• ci-updates
• clear-poison
• clippy
• clippy-lints
• dependabot/add-v2-config-file
• dependabot/cargo/cbindgen-0.14
• dependabot/cargo/cbindgen-0.15
• dependabot/cargo/cbindgen-0.16
• dependabot/cargo/cbindgen-0.17
• dependabot/cargo/cbindgen-0.18
• dependabot/cargo/cbindgen-0.19
• dependabot/cargo/cbindgen-0.20
• dependabot/cargo/cbindgen-0.21
• dependabot/cargo/cbindgen-0.22
• dependabot/cargo/cbindgen-0.23
• dependabot/cargo/cbindgen-0.24
• dependabot/cargo/cbindgen-0.25
• dependabot/cargo/cbindgen-0.26
• dependabot/cargo/crc32fast-1.4.2
• dependabot/cargo/crc32fast-1.5.0
• dependabot/cargo/criterion-0.4.0
• dependabot/cargo/criterion-0.5.0
• dependabot/cargo/criterion-0.6.0
• dependabot/cargo/criterion-0.7.0
• dependabot/cargo/esplugin-6.0.1
• dependabot/cargo/esplugin-6.1.0
• dependabot/cargo/esplugin-6.1.1
• dependabot/cargo/esplugin-6.1.2
• dependabot/cargo/esplugin-6.1.4
• dependabot/cargo/libc-0.2.155
• dependabot/cargo/libc-0.2.156
• dependabot/cargo/libc-0.2.157
• dependabot/cargo/libc-0.2.158
• dependabot/cargo/libc-0.2.159
• dependabot/cargo/libc-0.2.161
• dependabot/cargo/libc-0.2.162
• dependabot/cargo/libc-0.2.164
• dependabot/cargo/libc-0.2.165
• dependabot/cargo/libc-0.2.166
• dependabot/cargo/libc-0.2.167
• dependabot/cargo/libc-0.2.168
• dependabot/cargo/libc-0.2.169
• dependabot/cargo/libc-0.2.170
• dependabot/cargo/libc-0.2.171
• dependabot/cargo/libc-0.2.172
• dependabot/cargo/libc-0.2.173
• dependabot/cargo/libc-0.2.174
• dependabot/cargo/libc-0.2.175
• dependabot/cargo/libc-0.2.176
• dependabot/cargo/nom-6.0.0
• dependabot/cargo/nom-7.0.0
• dependabot/cargo/pelite-0.9.0
• dependabot/cargo/regex-1.10.5
• dependabot/cargo/regex-1.10.6
• dependabot/cargo/regex-1.11.0
• dependabot/cargo/regex-1.11.1
• dependabot/cargo/regex-1.11.2
• dependabot/cargo/regex-1.11.3
• dependabot/cargo/tempfile-3.11.0
• dependabot/cargo/tempfile-3.12.0
• dependabot/cargo/tempfile-3.13.0
• dependabot/cargo/tempfile-3.14.0
• dependabot/cargo/tempfile-3.15.0
• dependabot/cargo/tempfile-3.16.0
• dependabot/cargo/tempfile-3.17.0
• dependabot/cargo/tempfile-3.17.1
• dependabot/cargo/tempfile-3.18.0
• dependabot/cargo/tempfile-3.19.0
• dependabot/cargo/tempfile-3.19.1
• dependabot/cargo/tempfile-3.20.0
• dependabot/cargo/tempfile-3.21.0
• dependabot/cargo/tempfile-3.22.0
• dependabot/cargo/tempfile-3.23.0
• dependabot/cargo/unicase-2.8.0
• dependabot/cargo/unicase-2.8.1
• dependabot/github_actions/actions/checkout-5
• fix-case-sensitivity
• fix-ci
• fix-directory-handling
• fix-no-version-dll
• fix-partial-match
• fix-test
• fix-version-semver-comparison
• ghosted-plugins
• is-executable
• is-master-function
• master
• misc
• misc-tweaks
• move-test
• multiple-data-paths
• new-functions
• nom-5
• not-expressions
• openmw
• prep-5.3.3
• refs/tags/2.1.2
• refs/tags/2.2.0
• refs/tags/2.2.1
• refs/tags/2.2.2
• refs/tags/2.3.0
• refs/tags/2.3.1
• release-2.1.2
• release-2.2.0
• release-3.0.0
• release-5.3.1
• release/2.1.1
• remove-as
• remove-loot-alias
• resolve-warnings
• rust-2021
• starfield
• tarpaulin
• update-actions
• update-cbindgen
• update-esplugin
• update-nom
• update-runner
• update-tarpaulin
• windows-ci

Build # 5983913000

Build Type

push

github

Committed by Ortham

Commit Message

Avoid constructing paths using string literals

To avoid the chance of an issue involving a case-sensitive filesystem
and hardcoded string literals in loot-condition-interpreter.

However, I'm pretty sure this was a waste of time, because the library
input strings come from condition strings that do not necessarily
reflect the casing of filenames and paths in the filesystem that the
conditions are evaluated against, and that's much more likely to cause
issues.

Run Details

129 of 129 new or added lines in 3 files covered. (100.0%)

4104 of 4566 relevant lines covered (89.88%)

14.74 hits per line