locomotivemtl / charcoal-cms

21%

master: 21%

LAST BUILD ON BRANCH 0.9.1

branch: 0.9.1

CHANGE BRANCH

x

Reset

• 0.9.1
• 0.2
• 0.2.1
• 0.3
• 0.3.1
• 0.3.2
• 0.3.2.1
• 0.3.2.2
• 0.3.2.3
• 0.3.2.4
• 0.3.3
• 0.3.3.1
• 0.3.3.2
• 0.3.4
• 0.3.5
• 0.3.5.1
• 0.3.6
• 0.3.7
• 0.3.8
• 0.4
• 0.4.0.1
• 0.4.0.2
• 0.4.1
• 0.4.1.1
• 0.4.1.2
• 0.4.2
• 0.4.3
• 0.4.4
• 0.4.5
• 0.4.5.1
• 0.4.6
• 0.4.6.1
• 0.5.0
• 0.5.1
• 0.5.1.1
• 0.5.2
• 0.6.0
• 0.7.0.1
• 0.8.0
• 0.8.0.1
• 0.8.0.2
• 0.8.0.3
• 0.8.1
• 0.8.2
• 0.8.2.1
• 0.8.3
• 0.8.5
• 0.8.6
• 0.8.6.1
• 0.8.6.2
• 0.8.6.3
• 0.8.6.4
• 0.9.0
• 0.9.0.1
• 0.9.2
• 0.9.3
• 0.9.4
• 0.9.5
• 0.9.6
• 0.9.7
• cms_service_provider
• dlord-redux
• dlord-redux-styles
• dlord-relation
• feature/camelizePropertiesAndUseArrayAccess
• locale-from-host
• losted-patch-add_missing_properties_to_metatag_interface_json
• losted-patch-fix_routable_missing_get_prefix
• losted-patch-unit-tests
• master
• mcaskill-develop
• mcaskill-patch-3
• mcaskill-patch-web-template
• mcaskill-property-patch-6
• mcaskill-release
• mcaskill-translator
• mducharme-admin-metadata
• mducharme-translator

Build # 368

Build Type

push

travis-ci

Committed by mcaskill

Commit Message

Improve dynamic route handlers

Improved logic of route handlers to return 404 responses where the model or object route is missing, 500 responses when the model is invalid (such as incomplete templating details).

Added:
- Logs (debug/warning) to various route handlers to better track when issues arise
- Checks to validate rendered template view is not empty for matches the model's template identifier
- Catch to `*Route::load*FromPath()` methods to prevent nonexistent models from breaking the runtime
- Validation/Assertion methods to `GenericRoute` to determine if the context object or current object route are valid

Changed:
- Replaced 404 status codes with 500 when the failure does not stem from a missing model
- Refactored unit tests for route handlers

Run Details

779 of 3793 relevant lines covered (20.54%)

5.34 hits per line