lkiesow / pyCA

92%

master: %

LAST BUILD ON BRANCH no-pass

branch: no-pass

CHANGE BRANCH

x

Reset

Sync Branches

• no-pass
• 400
• all-command
• allow-reupload-finished-uploads
• bandit
• cfg-file
• check-merge-conflict
• codeql-pycurl
• container-docs
• coveralls-github
• default-reload
• dep-updates
• dont-show-active-event-twice
• drop-ui-server
• el8-flask
• fix-bandit
• fix-reupload
• flake8-err
• flask-version
• github-actions
• install-docs
• js-up
• master
• no-dc-upload
• npm-updates
• prometheus-client-version
• rm-axios
• schedule
• selenium
• serve-api-events
• skip-catalog-ingest-option
• sont-run-on-dependabot-twice
• test
• test-request-data
• title
• toc
• vue-components

Build # 5906618815

Build Type

push

github

Committed by lkiesow

Commit Message

Fix configuration without authentication

If an empty password was configured in the user interface configuration,
instead of requiring no authentication, pyCA would throw an internal
server error:

```
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 2528, in wsgi_app
    response = self.full_dispatch_request()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1825, in full_dispatch_request
    rv = self.handle_user_exception(e)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1823, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lars/dev/opencast/pyCA/pyca/ui/utils.py", line 16, in decorated
    or auth.username != config('ui', 'username') \
       ^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'username'
```

This patch fixes the issue.

Run Details

6 of 6 new or added lines in 1 file covered. (100.0%)

961 of 1050 relevant lines covered (91.52%)

3.66 hits per line