letsencrypt / pebble

6%

master: 8%

LAST BUILD ON BRANCH main

branch: main

CHANGE BRANCH

x

Reset

• main
• account-challgne-00
• ari-override
• ari-response-type
• ari-truncate
• challtestsrv-log-less
• cpu-custom-redirect-status-code
• cpu-docker-use-go12
• cpu-fix-cname-clear
• cpu-fix-keyrollover-err-check
• cpu-go-1-13
• cpu-go-1-13-now
• cpu-go-go-speed-racer
• cpu-go12
• cpu-mention-non-default-ports
• cpu-mock-servfail
• cpu-no-account-id-field-marshal
• cpu-no-clock-dep
• cpu-no-pebble-client
• cpu-pag-dir-and-nonce
• cpu-readme-subprobs
• cpu-repo-normalize
• cpu-stricter-than-your-gradeschool-teacher
• cpu-tls-one-three
• cpu-use-latest-docker
• dependabot/go_modules/github.com/go-jose/go-jose/v4-4.0.5
• dependabot/go_modules/github.com/miekg/dns-1.1.25
• dependabot/go_modules/golang.org/x/crypto-0.35.0
• dependabot/go_modules/golang.org/x/net-0.36.0
• dependabot/go_modules/golang.org/x/net-0.38.0
• fix-akid_certs
• fix-ci
• http-chunked-encoded-requests
• master
• mattm-deps
• mattm-go-jose
• mattm-golangcilint
• newcert
• no-finalize-loc
• order-for-display-race
• orders-not-deactivated
• parseTimeAlgoCheck
• rand-seed
• revoked-duplicate
• test-cpu-go-go-speed-racer
• update-dns-account-01
• user-action
• v2.0.1
• v2.0.2
• v2.1.0
• v2.2.0
• v2.2.1
• v2.2.2
• v2.3.0
• v2.3.1
• vancluever-profile-default-promote

Build # 17563607456

Build Type

push

github

Committed by web-flow

Commit Message

Revert "Add Location header to finalize response (#85)" (#509)

This reverts commit 9c3d91bf5, which was
merged as a result of https://github.com/letsencrypt/pebble/pull/85.
That PR based on the idea that the Location header is required to be
included with the Finalize response in RFC 8555, but this is not the
case: it appears in the example response, but its inclusion there is not
mandated by the text.

Although Boulder does provide the Location header in Finalize responses,
there exist other ACME implementations which do not. Therefore it is
useful for Pebble to omit it, so that clients developed against Pebble
do not come to rely on its inclusion.

Fixes https://github.com/letsencrypt/pebble/issues/508

Run Details

270 of 4464 relevant lines covered (6.05%)

0.28 hits per line