ld4l / open_annotation_rdf

99%

master: 98%

LAST BUILD ON BRANCH body_is_blank_node-naomi

branch: body_is_blank_node-naomi

CHANGE BRANCH

x

Reset

• body_is_blank_node-naomi
• 0.0.10
• 0.0.11
• 0.0.12
• 0.0.8
• 0.0.9
• 0.1.0
• 0.2.0
• AT_0.10_upgrade
• AT_dev
• add_casting_restrictions
• body_is_blank_node
• fix9_unlock_gem_versions
• fix_ruby_2.0
• master
• setup_coveralls
• tweaks
• upgrade_0.8

Build # 31

Build Type

push

travis-ci

Committed by elrayle

Commit Message

Fix failing test

* FIX TEST:  Push graph into repository instead of model
* FIX TEST:  Comment out expect(body.format) because format isn't a property of TagBody -- We can discuss whether it should be.  I am not opposed at all to adding format property.
* FIX CODE:  When I changed from TagAnnotation.new to Annotation.resume, the resume method failed to resume a TagAnnotation because the motivatedBy class was not RDF::Vocabulary::Term as it was for my tests.  It was RDF::URI.  I removed the kind_of? part of the validation for now and will rethink it.
* Show how Annotation.resume can be used to resume an annotation without knowing the type (comment, tag, or semantic tag) before hand
* Added format to the triples -- Not required for tests to pass.  This is so you can look at the model and see how statements that don't match a property are handled by ActiveTriples::Resource

See also:
spec/ld4l/open_annotation_rdf/annotation_spec.rb
describe '#resume' do
    context "when annotation body is a blank node" do

My tests don't use RDF::Graph to create the triples.  There is potential for side effects by using my models and methods to create the triples.  I like the way your test creates the triples.

It would be excellent to add a test for each of your fixtures, uses RDF::Graph to create the triples, and test the resulting resumed objects.  When using Annotation.resume, those tests would go in annotation_spec.  If using .new for one of the specific annotation models (CommentAnnotation, TagAnnotation, or SemanticTagAnnotation) then the tests would go in the corresponding model test (comment_annotation_spec, tag_annotation_spec, or semantic_tag_annotation_spec).

Run Details

2154 of 2179 relevant lines covered (98.85%)

12.05 hits per line