kubevirt / hyperconverged-cluster-operator
72%
main: 76%

LAST BUILD BRANCH: bump_MIGRATION_OPERATOR_v0.0.14_main
DEFAULT BRANCH: main
Repo Added
Files 115
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH release-1.14
branch: release-1.14
CHANGE BRANCH
x

coverage: 72.256% (-0.2%) from 72.483%
20689747098

push

github

web-flow 
[release 1.14] Add ValidatingAdmissionPolicy to validate the HyperConverged namespace (#3940)

* Add the new admission policy controller

The current implementation of preventing the creation of the
HyperConverged CR in non-allowed namespace, is not working in Openshift,
where becasue of a race condition, the webhook's namespace selector is
removed by OLM.

This commit adds a new controller, to create and reconcile a
ValidatingAdmissionPolicy and the related
ValidatingAdmissionPolicyBinding, to perform the same validation.

The reason we're doing it in a new controller, is because we need the
ValidatingAdmissionPolicy to be set, even if the HyperConverged CR is
not deployed, while our main controller only reconciles resources if
the HyperConverged CR is deployed.



* Register the admission policy controller on boot



* Remove the current validation

Remove the existing validation of the HyperConverged CR namespace from
the validation webhook, as it is now done by the policy, created by the
admission policy controller.



* Don't remove the namespace selector from the validation wh

OLM adds a namespace selection on the validation webhook CR, causing the
namespace validation to be not relevant.

The webhook setup logic removes this selector, but actually this is
reconciled by OLM, and eventually, user can still create the
HyperConverged CR in any namespace.

The issue is now handled by a ValidationgAdmissionPolicy, and so we
don't need this logic anymore, and so this commit removes it.



---------

Signed-off-by: Nahshon Unna Tsameret <nahsh.ut@gmail.com>

138 of 215 new or added lines in 3 files covered. (64.19%)

6 existing lines in 2 files now uncovered.

6675 of 9238 relevant lines covered (72.26%)

0.8 hits per line

Relevant lines Covered
9238 RELEVANT LINES 6675 COVERED LINES
0.8 HITS PER LINE
Source Files on release-1.14

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
20689747098 release-1.14 [release 1.14] Add ValidatingAdmissionPolicy to validate the HyperConverged namespace (#3940) * Add the new admission policy controller The current implementation of preventing the creation of the HyperConverged CR in non-allowed namespace, is n... push web-flow github
72.26
20621006319 release-1.14 [release-1.14] Use OpenShift Route in Alertmanager tests (#3898) * Use OpenShift Route in Alertmanager tests Signed-off-by: machadovilaca <machadovilaca@gmail.com> * downgrade AAQ to v1.3.0 Only downgrade the go module, not the images. This i... push web-flow github
72.48
19859446007 release-1.14 On metric token refresh, also delete the ServiceMonitor (#3790) (#3795) Currently, on token refresh, we're recreating the secret. But Prometheus does not fetch the new secret, and fails to access the metrics endpoint, rceiving 401 from the pod. ... push web-flow github
72.5
19503378613 release-1.14 Bump AAQ to v1.3.1 (#3735) Signed-off-by: HCO Bump Bot <noreply@github.com> Co-authored-by: kubevirt-bot <25687724+kubevirt-bot@users.noreply.github.com> push web-flow github
72.3
19298476210 release-1.14 csv-merger: make Replaces field optional in the CSV (#3853) When using an FBC catalog, the upgrade graph is not determined by the replaces,skips and skipRange fields in the CSV itself, but in the file-based catalog. Make the replaces-csv-version ... push web-flow github
72.26
18814613228 release-1.14 Fix kubevirt_hco_system_health_status (#3726) (#3819) Fix kubevirt_hco_system_health_status. System health should remain healthy during upgrade progression. Signed-off-by: Shirly Radco <sradco@redhat.com> Co-authored-by: Shirly Radco <sradco@red... push web-flow github
72.25
17581526508 release-1.14 [1.14] NodeNetworkInterfaceDown alert fires for disabled NICs (#3749) Signed-off-by: avlitman <alitman@redhat.com> push web-flow github
72.27
16891693951 release-1.14 [release-1.14] Force recreate metrics endpoint secret (#3701) * Force recreate metrics endpoint secret Signed-off-by: João Vilaça <machadovilaca@gmail.com> * Avoid reconciler nil objects Signed-off-by: João Vilaça <machadovilaca@gmail.com> --... push web-flow github
72.22
16877067434 release-1.14 [1.14] Fix monitoring linter (#3696) Signed-off-by: avlitman <alitman@redhat.com> push web-flow github
72.19
16873515646 release-1.14 Remove RWX filesystem mode requirement from vmStateStorageClass (#3694) Signed-off-by: Samuel Albershtein <salbersh@redhat.com> push web-flow github
72.19
See All Builds (16412)