kubernetes-sigs / lws

56%

main: 56%

LAST BUILD ON BRANCH feature/disaggregatedset-controller

branch: feature/disaggregatedset-controller

CHANGE BRANCH

x

Reset

• feature/disaggregatedset-controller
• add-redhat-adopters
• addEnvVarsIfNotExists
• adopters-kubeflow-data-cache
• bump-1.35
• change-helm-versioning
• chore/bump-go-1.26
• chore/quiet-dependabot
• chore/update-k8s-1.36
• codespell
• codex/chore-migrate-disaggregatedset-assets
• codex/chore-remove-standalone-disaggregatedset
• codex/docs-disaggregatedset
• dependabot/go_modules/disaggregatedset/go.opentelemetry.io/otel/sdk-1.40.0
• dependabot/go_modules/disaggregatedset/go.opentelemetry.io/otel/sdk-1.43.0
• dependabot/go_modules/disaggregatedset/google.golang.org/grpc-1.79.3
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.26.0
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.27.1
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.27.2
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.27.3
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.27.4
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.27.5
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.28.1
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.28.2
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.28.3
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.29.0
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.30.0
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.31.0
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.32.0
• dependabot/go_modules/github.com/onsi/gomega-1.38.3
• dependabot/go_modules/github.com/onsi/gomega-1.39.0
• dependabot/go_modules/github.com/onsi/gomega-1.39.1
• dependabot/go_modules/github.com/onsi/gomega-1.40.0
• dependabot/go_modules/github.com/onsi/gomega-1.41.0
• dependabot/go_modules/github.com/onsi/gomega-1.42.0
• dependabot/go_modules/github.com/onsi/gomega-1.42.1
• dependabot/go_modules/github.com/open-policy-agent/cert-controller-0.15.0
• dependabot/go_modules/github.com/open-policy-agent/cert-controller-0.16.0
• dependabot/go_modules/github.com/stretchr/testify-1.11.1
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.40.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.43.0
• dependabot/go_modules/google.golang.org/grpc-1.79.3
• dependabot/go_modules/kubernetes-00af733091
• dependabot/go_modules/kubernetes-43ae90ced9
• dependabot/go_modules/kubernetes-5ee042d875
• dependabot/go_modules/kubernetes-7147a9a324
• dependabot/go_modules/kubernetes-9918f4938d
• dependabot/go_modules/kubernetes-a891f8e759
• dependabot/go_modules/kubernetes-afec0813d8
• dependabot/go_modules/kubernetes-bb9e953d13
• dependabot/go_modules/kubernetes-e1e0f31a3a
• dependabot/go_modules/kubernetes-f18252b65b
• dependabot/go_modules/sigs.k8s.io/controller-runtime-0.22.3
• dependabot/go_modules/sigs.k8s.io/controller-runtime-0.22.4
• dependabot/go_modules/sigs.k8s.io/controller-runtime-0.23.1
• dependabot/go_modules/sigs.k8s.io/controller-runtime-0.23.3
• dependabot/go_modules/sigs.k8s.io/structured-merge-diff/v6-6.3.1
• dependabot/go_modules/sigs.k8s.io/structured-merge-diff/v6-6.3.2
• dependabot/go_modules/sigs.k8s.io/structured-merge-diff/v6-6.4.0
• dependabot/npm_and_yarn/site/all-0a4fd6b046
• dependabot/npm_and_yarn/site/all-0c3dee76c8
• dependabot/npm_and_yarn/site/all-1caf817742
• dependabot/npm_and_yarn/site/all-35a66b513d
• dependabot/npm_and_yarn/site/all-5f44a83626
• dependabot/npm_and_yarn/site/all-6c5fa6d165
• dependabot/npm_and_yarn/site/all-9e038a8bb8
• dependabot/npm_and_yarn/site/all-acbc8633e7
• dependabot/npm_and_yarn/site/all-b9edaaa523
• dependabot/npm_and_yarn/site/all-be790f7a9e
• dependabot/npm_and_yarn/site/all-ce9d680402
• dependabot/npm_and_yarn/site/docsy-0e2ad18
• dependabot/npm_and_yarn/site/docsy-2c84dd3
• dependabot/npm_and_yarn/site/docsy-4296f5c
• dependabot/npm_and_yarn/site/docsy-69d4d6c
• dependabot/npm_and_yarn/site/docsy-818f62f
• dependabot/npm_and_yarn/site/docsy-82d492b
• dependabot/npm_and_yarn/site/docsy-b23e453
• dependabot/npm_and_yarn/site/multi-bf05dc1ecf
• dependency-bump
• doc-update-restart-policy
• feat/disaggregatedset-planner
• feat/helm-merge-disaggregatedset
• feat/nominate-yankay-approver
• feature/disaggregatedset-hpa
• feature/patch-1
• feature/percentage-block-planner
• feature/percentage-block-planner-v2
• fix-Failing-1.35
• fix-ambiguous-registry
• fix-hf-token
• fix-label
• fix-manifests
• fix-security-policy-violations
• fix/cloudbuild-gcb-docker-gcloud-tag
• fix/disaggregatedset-active-revision-waiter
• fix/disaggregatedset-active-revision-waiter-roles
• fix/disaggregatedset-sample-worker-template
• fix/e2e-kind-1.36
• fix/e2e-test-assertion-improvements
• fix/flaky-progressing-state-test
• fix/leader-pod-recreated-twice
• fix/makefile-and-docs
• fix/use-staging-registry-variable-in-clean-manifests
• fix_trivy_ci_findings
• fixed-helm
• init_owned_slice
• integration-test-fix
• kep-820-fail-fast-dns
• kep-disagg-deployment
• kep-disaggregatedset-placement-policy
• kep-disaggregatedset-slices
• kep/666-gang-scheduling-in-lws
• kep/failed-limit-init-dns
• kueue-update-tas
• leader-sts-delete
• lws-kueue
• main
• maxunavailable-0
• mostafa/lws-better-malformed-feedback
• planner-rolling-updates-doc-clarification
• pod-restart-fix
• podRestartAfterStart-to-snake
• readme-phase-to-role
• refs/tags/v0.8.0
• refs/tags/v0.9.0
• release-0.8
• release-0.9
• remove-leader-pod-watch
• remove_unused_code
• review/lws
• security/update-trivy-action-v0.35.0
• slices
• test-coverage
• tpu-env
• update-1-36
• update-doc
• update-one-replica
• upgrade-go-1.25
• upgrade-go-1.25.5
• upgrade-hugo2
• version
• version-fix
• vllm-guides-updates
• volume-claim-templates-example

Build # 26613607669

Build Type

Pull #836

github

Committed by hasB4K

Commit Message

Remove redundant cleanupOldLWS from simple reconcile path

cleanupDrainedLWS already runs at the start of every reconcile and
handles all old revisions where every role is at 0 replicas. The
simple path is only reached when totalOldReplicas == 0, so
cleanupDrainedLWS has already cleaned them up.

Signed-off-by: Mathis Felardos <mathis@mistral.ai>

Pull Request Pull Request #836: [DisaggregatedSet][2/N] Add controller implementation with rolling update support

Coverage Stats

966 of 1173 new or added lines in 6 files covered. (82.35%)

124 existing lines in 1 file now uncovered.

2150 of 3830 relevant lines covered (56.14%)

46.09 hits per line