kubernetes-sigs / cluster-api-provider-kubevirt

59%

main: 40%

LAST BUILD ON BRANCH fix-294

branch: fix-294

CHANGE BRANCH

x

Reset

Sync Branches

• fix-294
• 274-remove_hostpath_volume
• activate-net-multiqueue
• add-all-templates-to-release
• add-approver-rmohr
• add-coverage-file
• add-file-to-release
• add-more-failure-conditions-v1
• add-nahshon-to-owners
• add-secret-labels
• add_vm_live_migratable_condition
• adjust-e2e-timeouts
• allow-e2e-multiple-times
• allow-insecure-registry-podman
• append-owners
• approvers
• auto-approve-github-action
• auto_sync_upstream_2022-03-09
• auto_sync_upstream_2022-10-21-06-12
• auto_sync_upstream_2023-03-29-12-55
• auto_sync_upstream_2023-10-22-06-29
• auto_sync_upstream_2023-11-14-09-31
• bubble-cond
• bump-all
• bump-boot-v1.32.1
• bump-boot-v1.33.5
• bump-boot-v1.34.1
• bump-capi-1.10-beta0
• bump-capk-version
• bump-cluster-api
• bump-controller-runtime
• bump-deps
• bump-go-1.20
• bump-images
• bump-k8s-deps
• bump-metallb
• bump_api-cluster-1.11.1
• bump_kubevirt
• bump_kv
• check-make-generate
• chore/declarative-golangci-lint
• cluster-class
• cluster-deletion-race
• cluster-template-lb
• clusterctl-integration
• clusterkubevirtadm
• clusterkubevirtadm-fix
• clusterkubevirtadm-kubevirtci
• clusterkubevirtadm-role
• controller-unit-tests
• cpendpoint
• debug-e2e
• dnm-test-kind-ovn-multinet
• docs-pci-passthrough
• drain-node
• dv-import-fail-reason
• e2e-env
• e2e-test
• e2e-test-fix
• e2e-testsuite
• e2e_sonobuoy_conformance
• external-poll-interval
• externally-managead-fix
• failure-reasons-v1
• fake-pr
• fix-258
• fix-bug-kv-cluster-race
• fix-capk-user-add
• fix-cve
• fix-cves
• fix-e2e
• fix-e2e-test
• fix-e2e-test-go
• fix-e2e-test-lane
• fix-external-deletion
• fix-go-ver
• fix-infra-secret-lookup
• fix-issue-62
• fix-namespace-logic
• fix-patch-of-deleted-failure
• fix-release
• fix-secret-reconcile
• fix-slakc-link
• fix-unit-test
• flatcar-template
• force-bump-dep
• gen-client
• getting-started-placeholder
• goimports
• golinter
• ignore-missing-ssh
• image-builder-docs
• image-builder-integration
• improve-linter
• integrate-kubevirt-dump
• issue-84
• issue-98
• issue/64
• issue/90
• kccm-v0.5.0
• kubevirt-0.58.0
• kubevirtci-add-curl-lb-namespace
• kubevirtci-call-fetch-when-necessary
• kubevirtci-metal-lb
• kubevirtci-tenant-access
• kubevirtci-updates
• lb
• main
• mkpj-fail
• move-to-ginkgov2
• move-to-go-1.18
• network-fixes
• no-vm-vmi-watch
• node-drain-external
• none-mode
• noop_check_ci
• ok-to-test-fix
• os-main
• passt_binding
• passt_binding_2
• persistent-vms
• pin-kubevirt-release
• poc-cloud-provider
• protect-github-actions
• radim-quique-collab
• rbac
• refactor-e2e
• reflect-vm-status-to-cluster
• refs/tags/v0.1.0
• refs/tags/v0.1.0-rc.0
• refs/tags/v0.1.1
• refs/tags/v0.1.10
• refs/tags/v0.1.2
• refs/tags/v0.1.3
• refs/tags/v0.1.4
• refs/tags/v0.1.5
• refs/tags/v0.1.6
• refs/tags/v0.1.7
• refs/tags/v0.1.8
• refs/tags/v0.1.9
• remove-IMAGE_REPO
• revert-144-e2e-test-fix
• revert-183-passt_binding
• servciecidr
• spike-sec-bridge-cni
• stable-ip-v1
• switch-to-rook-storage-class
• sync-script
• sync_upstream_2025-01-20
• test
• test-artifacts-fix-dump-version
• test-new-1.23-img
• test-pr-dont-merge
• test_pr
• tilt_provider
• topology-dryrun-check
• units-tests
• update-client-go
• update-e2e-to-k8s1.23
• update-go-net
• update-golang-version
• update-image-1.24
• update-kubevirtci-guest-image-k8s-1.23
• update-templates
• update_clusterctl_metadata_version
• use-nocloud-when-specified

Build # 11230934780

Build Type

Pull #295

github

Committed by nunnatsa

Commit Message

Allow annotate and label KubevirtClusterTemplates

The current CRD does not allow modification of any field in KubevirtClusterTemplate
resources. That prevent user to add annotations or labels to the
templates, and that does not follow the regular behavior of K8s.

In addition, the new capi is trying to annotate templates, and failed to
do that, and this is an actual bug.

This PR fixes the issue by making only the `Spec` field as read only,
letting modifiying the metadata fields as in any K8s resource.

Pull Request Pull Request #295: Allow annotate and label KubevirtClusterTemplates

Run Details

1570 of 2650 relevant lines covered (59.25%)

10.8 hits per line