klokare / decimal
92%

DEFAULT BRANCH: master
Repo Added
Files 12
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

coverage: 92.43%. First build
#1

push

klokare 
Fix the two CI failures, and close the gap that let one through

The 32-bit job caught a real hole. Three test assertions passed an untyped
constant to FromInt, which infers int -- 32 bits on a 386 or arm target, so
FromInt(math.MinInt64) does not compile there. The library itself was fine;
the build step passed and only the test step failed.

One of the three could not be fixed with a cast. It guarded a 64-bit
literal behind `if bits := ^uint(0) >> 63; bits == 1`, which does nothing:
Go type-checks both branches, so the constant still has to fit. It now
checks the platform's own boundary with math.MinInt and math.MaxInt, which
is the invariant that actually matters for Int and Uint and holds on 32-
and 64-bit alike.

`make cross` used `go build`, and build ignores _test.go files -- which is
exactly why this passed locally and failed in CI. It now uses `go vet`,
which type-checks the tests, and the CI per-architecture step does the
same. Both would have caught this before the push.

The lint job failed for an unrelated reason: golangci-lint-action v6 only
understands golangci-lint v1 version strings, so pinning v2.13.1 made it
error out. Bumped to the v7 action.

Worth recording what did pass: the s390x job ran the full suite under QEMU
and was green, so the big-endian word accessors are now verified by an
actual test run rather than only by compiling.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

3260 of 3527 relevant lines covered (92.43%)

21825.01 hits per line

Relevant lines Covered
3527 RELEVANT LINES 3260 COVERED LINES
21825.01 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
#1 master Fix the two CI failures, and close the gap that let one through The 32-bit job caught a real hole. Three test assertions passed an untyped constant to FromInt, which infers int -- 32 bits on a 386 or arm target, so FromInt(math.MinInt64) does not... push klokare
92.43
See All Builds (1)