kiva / ui
85%

DEFAULT BRANCH: main
Repo Added
Files 408
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 84.632% (-0.01%) from 84.644%
27433165934

push

github

web-flow 
feat: render optional tip section in admin reward LC checkout variant b (MP-2840) (#6977)

* feat: render optional tip section in admin reward LC checkout variant b

Wires the `stop_hiding_tip_campaign` experiment (MP-2852) into the LC
checkout UI. When an eligible Admin Reward lender is bucketed into
variant `b`, the frontend injects an `isTip: true` Donation into the
basket so the existing `DonationItem` renders the standard tip section.
For variant `a` (control), `reward_credit` LC checkouts continue to
suppress the tip exactly as today.

Ticket: https://kiva.atlassian.net/browse/MP-2840
Parent epic: MP-2829 (Stop hiding tip - LC Campaigns)
Depends on: MP-2839 (helper, #6967), MP-2852 (bucketing, #6970)
Followed by: MP-2841 (Playwright)

Why the injection is a frontend mutation rather than a `v-if`:
Tip suppression for `reward_credit` LC checkouts is structural — the
backend simply omits the `isTip: true` Donation from
`shop.basket.items.values`. `BasketItemsList` renders whatever
donations are in the basket; there is no UI-side gate to flip. To
"show the tip" the frontend must put a tip Donation into the basket.

Changes in src/pages/Checkout/CheckoutPage.vue:

- Import `setDonationAmount` from `#src/util/basketUtils` — the
  canonical wrapper around the `updateDonation` mutation that
  `DonationItem` itself uses. Backend upserts on `isTip` within the
  basket, so this both creates the donation when absent and updates
  it when present.

- Add `ensureTipDonationExists()` method:
    * Short-circuits on `emptyBasket` to avoid a race with the
      `emptyBasket` watcher (see below).
    * Computes `donationAmount` as
      `TIP_PERCENTAGE * (loanReservationTotal + kivaCardTotal)`,
      quantized to 2 decimals so the equality check can never miss
      due to float representation.
    * Reads any existing tip from `this.donations` and skips the
      mutation when the existing price is non-zero (preserves a
      user-entered tip) OR already equals ... (continued)

5242 of 5759 branches covered (91.02%)

Branch coverage included in aggregate %.

26 of 38 new or added lines in 1 file covered. (68.42%)

41282 of 49213 relevant lines covered (83.88%)

35.81 hits per line

Relevant lines Covered
49213 RELEVANT LINES 41282 COVERED LINES
35.81 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
27433165934 main feat: render optional tip section in admin reward LC checkout variant b (MP-2840) (#6977) * feat: render optional tip section in admin reward LC checkout variant b Wires the `stop_hiding_tip_campaign` experiment (MP-2852) into the LC checkout UI... push web-flow github
84.63
27423976021 main Merge pull request #6983 from kiva/CIT-4402_link_matching_partner_to_dash feat: link contributing partners to dash push web-flow github
84.64
27380426614 main Merge branch 'production' push kiva-robot github
84.65
27373500127 main feat: route guard added to test (#6981) push web-flow github
84.65
27362460467 main Merge pull request #6976 from kiva/MP-2871 feat: integrate goal row to next steps page push web-flow github
84.66
27356515400 main Merge pull request #6975 from kiva/CIT-4370_multi_matching_profile_and_basket feat: add multi matching to basket line and profile section push web-flow github
84.66
27354992105 main Merge pull request #6978 from kiva/MP-2869--qa-fixes fix: missing tracking events to match goal card and minor style changes push web-flow github
84.63
27308610822 main Merge pull request #6973 from kiva/CIT-4370_multi_matching_sidebar feat: added matching info in the sidebar for multi matching push web-flow github
84.61
27303942412 main Merge pull request #6974 from kiva/fix-cit-ui-update-KvWwwHeaderBasic fix: update kv-components and loanSearchSuggestions fetch for KvWwwHe… push web-flow github
84.6
27301978178 main Merge pull request #6955 from kiva/feature/mp-2747-add-express-checkout-modal-in-thankyou-page feat: [MP-2747] - add express checkout modal in thankyou page after set goal push web-flow github
84.59
See All Builds (19260)