kelindar / bitmap

92%

LAST BUILD ON BRANCH main

branch: main

CHANGE BRANCH

x

Reset

• main
• GLO-607-add-hex-marshalling
• aggregate
• aggregations
• avx2count
• batched
• checks
• deps
• filter
• fix
• fix-empty
• fix-noescape
• gocc
• header
• omit-frame-pointer
• popcount
• range
• readfrom
• readme
• refs/tags/v1.0.10
• refs/tags/v1.0.11
• refs/tags/v1.0.12
• refs/tags/v1.0.4
• refs/tags/v1.0.5
• refs/tags/v1.0.6
• refs/tags/v1.0.7
• refs/tags/v1.0.8
• refs/tags/v1.0.9
• refs/tags/v1.1.0
• refs/tags/v1.1.1
• refs/tags/v1.1.2
• refs/tags/v1.1.3
• refs/tags/v1.1.4
• refs/tags/v1.1.5
• refs/tags/v1.2.0
• refs/tags/v1.2.1
• refs/tags/v1.2.2
• refs/tags/v1.3.0
• refs/tags/v1.4.0
• refs/tags/v1.4.1
• refs/tags/v1.5.0
• refs/tags/v1.5.1
• refs/tags/v1.5.2
• refs/tags/v1.5.3
• refs/tags/v1.5.4
• refs/tags/v1.5.5
• refs/tags/v1.5.6
• refs/tags/v1.5.7
• resize
• shrink
• trim

Build # 35854941643

Build Type

push

github

Committed by web-flow

Commit Message

Fix Or/Xor dropping bits when combining bitmaps of different lengths (#51)

* fix: union/xor of different-sized bitmaps drops bits in variadic path

Or and Xor with extra bitmaps used _or_many/_xor_many, which apply a single
word count to every input. The count came from pointersOf, whose length is
the maximum over the extra slice only and ignores other, so a longer other
lost its tail words. More generally a uniform count cannot combine operands
of different lengths: a longer source is truncated and a shorter one is read
past its end.

Fold each source in with the single-operand SIMD primitive over its own
length, matching the scalar reference in simd_generic.go. Fixes the amd64
accelerated and AVX-512 branches and the arm64 branch.

* Keep the _many primitives for equal-sized operands, fold only ragged ones

* test: cover longer ragged bitmap extras

---------

Co-authored-by: Roman <roman.atachiants@gmail.com>

Coverage Stats

0 of 15 new or added lines in 1 file covered. (0.0%)

586 of 635 relevant lines covered (92.28%)

450.88 hits per line