keenlabs / KeenClient-iOS

64%

master: 66%

LAST BUILD ON BRANCH fix_test_setup

branch: fix_test_setup

CHANGE BRANCH

x

Reset

• fix_test_setup
• 3-5-5-release-bits
• 3-5-6-release-bits
• 3.5.4
• 3.5.5
• 3.5.7
• 3.5.7_release
• 3.6.0
• 3.6.0_release
• 3.6.1
• 3.6.2
• 3.6.2_release
• 3.7.0
• 3.7.0_release
• add_example_apps_to_ci
• add_logging_hooks
• add_proxy_support
• add_proxy_support_2
• add_sdk_info_header
• clang_format
• custom_url_authority
• datasets
• disable_geolocation
• disable_reachability_flags
• fix_194
• fix_ci_error_reporting
• fix_db_corruption
• fix_documentation_warnings
• fix_duplicate_events_master
• fix_example_cartfiles
• fix_framework_build
• fix_geolocation_test
• fix_headers
• fix_pch
• fix_sqlite_date_formatting
• fix_tests
• fix_xcode_83_build
• geoloc_documentation
• issue_156
• issue_203_minor_revision_step
• list
• master
• ms_timestamp_report_errors_and_prior_attempts
• patch_release_3.6.1
• rate_limiting_proposal
• readme_swift
• saved_cached_queries
• saved_cached_queries_clang_format
• sqlite_fixes
• swift3_example
• update_changelog
• update_examples
• update_install_instructions
• update_travis
• update_travis_use_build_matrix
• upload_completion_block
• use_travis_build_matrix
• vnext_major
• vnext_minor
• vnext_patch

Build # 662

Build Type

push

travis-ci

Committed by baumatron

Commit Message

Fix cases where global state wasn't being reset between tests.

KeenClient's sharedClient returns nil when no projectid is set,
which leads to nasty side-effects for test setup. Basically, any
write or read key that was set wasn't getting cleared by setUp
because of this, and neither was currentLocation.

The workaround is to carefully reset state to defaults and set
the projectid to nil last. Changes to sharedClient behavior
proposed by PR #193 will improve this situation because sharedClient
will no longer return nil.

Run Details

1506 of 2348 relevant lines covered (64.14%)

37.72 hits per line