karenc / db-migrator

97%

master: 97%

LAST BUILD ON BRANCH close-db-connections

branch: close-db-connections

CHANGE BRANCH

x

Reset

• close-db-connections
• 0.1.1
• 0.1.2
• 0.1.3
• 0.1.4
• 0.2.0
• 1.0.0
• 1.0.1
• 1.0.2
• 1.1.0
• context
• db-config
• deferred-migrations
• devops-features
• fix-list-order
• fix-tests
• fix-version
• list
• list-by-applied
• logger
• mark
• mark-multiple
• master
• migrations-directory-and-context
• move-logger
• no-migrations-directory
• no-schema-no-error
• py3-schema-diff
• repeat-migrations
• super-user
• tests
• travis
• update-psycopg2
• update-readme
• version

Build # 193

Build Type

push

travis-ci

Committed by karenc

Commit Message

Explicitly close all postgres db connections

The psycopg2 db connection `with` statement does not actually close the
database connection causing lots of idle postgres connections on the
production servers.  An idle postgres connection can be found by doing
`ps aux` on the database servers, for example you will see something
like this:

```
postgres 25498  0.0  0.5 302652 10996 ?        Ss   09:31   0:00 postgres: cnxarchive cnxarchive 192.168.122.250(42646) idle
```

On http://initd.org/psycopg/docs/usage.html#with-statement

"Note that, unlike file objects or other resources, exiting the
connection’s with block doesn't close the connection but only the
transaction associated with it"

This change creates a `db_connect` function that is like
`psycopg2.connect` but closes the db connection when exiting the `with`
block.

Run Details

1022 of 1052 relevant lines covered (97.15%)

1.93 hits per line