jstasiak / python-zeroconf
94%
master: 94%

LAST BUILD BRANCH: fix_typing
DEFAULT BRANCH: master
Repo Added
Files 2
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix-unique-regression
branch: fix-unique-regression
CHANGE BRANCH
x

572

Pull #237

travis-ci

web-flow 
Remove uniqueness assertions

The assertions, added in [1] and modified in [2] introduced a
regression. When browsing in the presence of devices advertising SRV
records not marked as unique there would be an undesired crash (from [3]):

    Exception in thread zeroconf-ServiceBrowser__hap._tcp.local.:
    Traceback (most recent call last):
      File "/usr/lib/python3.7/threading.py", line 917, in _bootstrap_inner
        self.run()
      File "/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py", line 1504, in run
        handler(self.zc)
      File "/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py", line 1444, in <lambda>
        zeroconf=zeroconf, service_type=self.type, name=name, state_change=state_change
      File "/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py", line 1322, in fire
        h(**kwargs)
      File "browser.py", line 20, in on_service_state_change
        info = zeroconf.get_service_info(service_type, name)
      File "/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py", line 2191, in get_service_info
        if info.request(self, timeout):
      File "/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py", line 1762, in request
        out.add_answer_at_time(zc.cache.get_by_details(self.name, _TYPE_SRV, _CLASS_IN), now)
      File "/home/pi/homekit-debugging/venv/lib/python3.7/site-packages/zeroconf/__init__.py", line 907, in add_answer_at_time
        assert record.unique
    AssertionError

The intention is to bring those assertions back in a way that only
enforces uniqueness when sending records, not when receiving them.

[1] bef8f593ae82 ("Ensure all TXT, SRV, A records are unique")
[2] 5e4f496778d9 ("Refactor out unique assertion")
[3] https://github.com/jstasiak/python-zeroconf/issues/236
Pull Request #237: Remove uniqueness assertions

2109 of 2248 relevant lines covered (93.82%)

5.62 hits per line

Relevant lines Covered
2248 RELEVANT LINES 2109 COVERED LINES
5.62 HITS PER LINE
Source Files on fix-unique-regression
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
572 fix-unique-regression Remove uniqueness assertions The assertions, added in [1] and modified in [2] introduced a regression. When browsing in the presence of devices advertising SRV records not marked as unique there would be an undesired crash (from [3]): Except... Pull #237 web-flow travis-ci pending completion  
571 fix-unique-regression Remove uniqueness assertions The assertions, added in [1] and modified in [2] introduced a regression. When browsing in the presence of devices advertising SRV records not marked as unique there would be an undesired crash (from [3]): Except... push jstasiak travis-ci pending completion  
See All Builds (658)