jsor-labs / promise

98%

master: 99%

LAST BUILD ON BRANCH done-error

branch: done-error

CHANGE BRANCH

x

Reset

• done-error
• 2.x
• cancellation-queue-object-check
• enforce-exception-reasons
• fatal-error-refactoring
• fix-follower-cancellation-propagation
• fix-php-coveralls
• fix-queue
• follower-cancellation-propagation
• master
• recommend-throwing-over-reject
• remove-lazy-promise
• throwable-rejection-readme-fixes
• throwable-type-improvements

Build # 6

Build Type

push

travis-ci

Committed by jsor

Commit Message

Trigger an E_USER_ERROR instead of throwing an exception from done()

If an error (either a thrown exception or returned rejection) escapes the
done() callbacks, it will now cause a fatal error by using trigger_error() with
E_USER_ERROR instead of (re)throwing.

Because promise resolution is synchronous, those exceptions bubbled up to the
reject() call which mixed resolution and consumption parts.

Run Details

328 of 333 relevant lines covered (98.5%)

312.81 hits per line