jridgewell / minionette

100%

master: 100%

LAST BUILD ON BRANCH v2_performant_remove

branch: v2_performant_remove

CHANGE BRANCH

x

Reset

• v2_performant_remove
• master
• v1.6.0
• v1.6.1
• v1.7.0
• v2
• v2_collection_emptyView

Build # 143

Build Type

push

travis-ci

Committed by jridgewell

Commit Message

Use cascading triggers to trigger subview's "remove" event.

Since the "remove" event must happen before any of the view's DOM tree is removed,
we couldn't remove a top level view without calling #remove on each
subview (and their subviews). This was a **major** performance issue.
Using this cascading triggers technique, we might be able to
preemptively cause the "remove" event to happen on subviews before
actually calling #remove on them. With that we can just `$el.remove` the
top level view's element, and only have 1 reflow.

ping @jmeas, re: https://github.com/marionettejs/backbone.marionette/issues/2134

Run Details

265 of 265 relevant lines covered (100.0%)

231.22 hits per line