joelanford / operator-sdk

42%

master: 49%

LAST BUILD ON BRANCH helm-fix-finalizer

branch: helm-fix-finalizer

CHANGE BRANCH

x

Reset

• helm-fix-finalizer
• alpha-release-migrations
• ansible-helm-cobra
• ansible-helm-commit-info
• ansible-helm-log-fmt
• ansible-helm-main
• ansible-metrics-addr
• ansible-operator-env-v0.19
• better-cleanup
• boilerplate-run-bundle
• build-fix
• bump-operator-registry
• changelog-gen-fixes
• changelog-update
• circle-ci
• consistent-domain
• dependent-predicate
• doc-rm-helm-ansible-install
• docs-spacing
• docs-spacing-favicons
• fix-ansible-link
• fix-find-metadata-dir
• fix-helm-finalizers-permissions
• fix-internal
• fix-legacy-refs-docs
• fix-run-packagemanifests-e2e
• fix/csv-generate-path-segments
• fix/release-binaries
• fixed-build-image-names
• gen-bundle-namespaced
• generate-crds-non-go
• gh-actions
• gitignore-scorecard
• hardcode-sample-chart
• helm-ansible-main
• helm-ansible-version-metric
• helm-leader-election
• helm-make-run
• helm-metrics-addr
• helm-plugin-shortname
• helm-role-gen
• helm-role-init
• helm-schema
• inject-version
• install-instructions
• install-instructions-v0.19.x
• k8s-1-18
• kb-docs-ignore
• mac-arm64
• makefile-ci-reset
• multi-stage-dockerfiles
• mv-ansible-internal
• mv-version
• pin-ansible-community-kubernetes
• post-1.0.0-alpha-updates
• post-release-v0.19.4
• post-release-v1.0.1
• refactor-cleanup
• relax-csv-name-validation-v1.0.x
• release-helm-ansible-binaries
• release-v0.19.4
• release-v1.0.1
• rename-config-client
• rm-gopkg-yaml-helm
• rm-legacy-go
• rm-legacy-go-example-and-docs
• rm-legacy-go-fragment
• rm-legacy-run
• rm-maintainers
• rm-s390x-builds
• run-pkgman-allnamespaces
• run-pkgmnfs-writable-dir
• scorecard-fix-parallel-test-flake
• scorecard-label-perms
• scorecard-output-api
• scorecard-parallel
• scorecard-use-operator-config
• small-call-init-helm
• travis-deploy-consolidate
• use-ci-scorecard-images
• v0-19-x-ansible-helm-commit-info
• v0-19-x-fix-migration-link
• v0.19.x-bump-operator-registry
• v0.19.x-fix-auth-provider-imports
• v0.19.x-fix-run-packagemanifests
• v1.0.x-backports
• v1.0.x-fix-run-packagemanifests
• v1.0.x-use-ci-scorecard-images
• website-fix-colors

Build # 1099

Build Type

push

travis-ci

Committed by joelanford

Commit Message

pkg/helm/controller/reconcile.go: finalizer fix

This PR fixes a bug in the helm operator that caused the
CR to be unable to be deleted without manually intervening
to delete a prematurely added finalizer.

Helm operator now applies its uninstall finalizer only when
a release is deployed.

Run Details

3853 of 9198 relevant lines covered (41.89%)

4.39 hits per line