jmoiron / sqlx
74%
master: 74%

Repo Added 28 Feb 2018 03:58AM UTC

Files 7

Badge

Embed ▾

LAST BUILD ON BRANCH v1.3.1
branch: v1.3.1

CHANGE BRANCH
x

Reset

v1.3.1

master

pr-501

pr-529

pr-574

v1.2.0

v1.3.0

v1.3.2

v1.3.3

v1.3.4

Committed 25 Jan 2021 11:18PM UTC coverage: 73.71%. First build

Build # 193

Build Type

push

travis-ci

Committed by

jmoiron

Commit Message

fixes #688

The changes in #635 changed the some of the output types of In to
pointers.  This takes less time but it also changed the types in the
output of In in a way that I think is more aggressive than I would have
preferred.  I'm also not 100% convinced that using pointers to types like
`int` and `string` would provide an overall performance benefit when you
factor in GC.

Despite that, timings did get worse:

pre-change:

```
BenchmarkIn-4                3136129               376 ns/op             272
B/op           4 allocs/op
BenchmarkIn1k-4                   171588              6602 ns/op
19488 B/op             3 allocs/op
BenchmarkIn1kInt-4                157549              7502 ns/op
19488 B/op             3 allocs/op
BenchmarkIn1kString-4             155502              7604 ns/op
19488 B/op             3 allocs/op
```

post-change:

```
BenchmarkIn-4                    3007132               396 ns/op
272 B/op               4 allocs/op
BenchmarkIn1k-4                   175978              6768 ns/op
19488 B/op             3 allocs/op
BenchmarkIn1kInt-4                120422             10125 ns/op
19488 B/op             3 allocs/op
BenchmarkIn1kString-4             108813             10755 ns/op
19488 B/op             3 allocs/op
```

I'd prefer to keep `[]int{..}` producing ints instead of `*int` even if
it means losing ~25% of perf on these special cased functions.

Run Details

1200 of 1628 relevant lines covered (73.71%)

608.78 hits per line

Relevant lines Covered

1628 RELEVANT LINES 1200 COVERED LINES

608.78 HITS PER LINE

Source Files on v1.3.1

Recent builds

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
193	v1.3.1	fixes #688 The changes in #635 changed the some of the output types of In to pointers. This takes less time but it also changed the types in the output of In in a way that I think is more aggressive than I would have preferred. I'm also not 100...	push	26 Jan 2021 01:05AM UTC	jmoiron	travis-ci	73.71

See All Builds (197)

jmoiron / sqlx
74%
master: 74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v1.3.1
branch: v1.3.1

CHANGE BRANCH
x

Reset

v1.3.1

master

pr-501

pr-529

pr-574

v1.2.0

v1.3.0

v1.3.2

v1.3.3

v1.3.4

CHANGE BRANCH
x

Relevant lines Covered

Source Files on v1.3.1

Recent builds

jmoiron / sqlx 74% master: 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v1.3.1 branch: v1.3.1 CHANGE BRANCH x Reset v1.3.1 master pr-501 pr-529 pr-574 v1.2.0 v1.3.0 v1.3.2 v1.3.3 v1.3.4

CHANGE BRANCH x

Relevant lines Covered

Source Files on v1.3.1

Recent builds

jmoiron / sqlx
74%
master: 74%

README BADGES
x

LAST BUILD ON BRANCH v1.3.1
branch: v1.3.1

CHANGE BRANCH
x

Reset

v1.3.1

master

pr-501

pr-529

pr-574

v1.2.0

v1.3.0

v1.3.2

v1.3.3

v1.3.4

CHANGE BRANCH
x