jgraichen / restify

91%

master: 91%

LAST BUILD ON BRANCH fl/empty-dependencies

branch: fl/empty-dependencies

CHANGE BRANCH

x

Reset

• fl/empty-dependencies
• celluloid
• dependabot/bundler/rubocop-tw-0.65.0
• em-pool
• fail-mix-on-400-500
• fl/em-pool
• fl/head-requests
• fl/header-precedence
• fl/header-typo
• fl/http-exception-subclasses
• fl/msgpack
• franzliedke-patch-1
• jg/caching
• jg/timeout
• logging
• master
• v0.1.1
• v0.1.2
• v0.2.0
• v0.3.0
• v0.3.1
• v0.3.2
• v0.4.0
• v0.4.0.b1
• v0.5.0
• v1.0.0
• v1.0.1.beta1
• v1.1.0
• v1.10.0
• v1.2.0
• v1.2.1
• v1.3.0
• v1.3.1
• v1.4.0
• v1.4.1
• v1.4.2
• v1.4.3
• v1.4.4
• v1.5.0
• v1.6.0
• v1.7.0
• v1.8.0
• v1.9.0
• v1.9.0.rc1

Build # 333

Build Type

Pull #18

travis-ci

Committed by web-flow

Commit Message

Fix promise resolution with empty array of deps

When building a promise with a dynamic array of dependencies, this array
can sometimes be empty. This behavior was currently not specified. We
expect this promise to return an empty array, which would be consistent
with the return value for multiple input dependencies (an array with one
result per input promise).

There is one other case when this situation (no task, no dependencies)
can happen: external promise resolution using a `Writer` object, e.g.
through `Restify::Promise.fulfilled`. To differentiate these cases, we
explicitly check for one or more empty arrays being passed in.

Pull Request Pull Request #18: Fix promise resolution with empty array of deps

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

715 of 786 relevant lines covered (90.97%)

187.21 hits per line