• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

jgraichen / rails-rfc6570
96%
master: 96%

Build:
Build:
LAST BUILD BRANCH: dependabot/bundler/rubocop-tw-0.81.0
DEFAULT BRANCH: master
Repo Added 05 Jun 2014 01:53PM UTC
Files 4
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH jg/formatter
branch: jg/formatter
CHANGE BRANCH
x
Reset
  • jg/formatter
  • dependabot/bundler/rubocop-tw-0.65.0
  • dependabot/bundler/rubocop-tw-0.66.0
  • dependabot/bundler/rubocop-tw-0.67.1
  • dependabot/bundler/rubocop-tw-0.68.0
  • dependabot/bundler/rubocop-tw-0.69.0
  • dependabot/bundler/rubocop-tw-0.70.0
  • dependabot/bundler/rubocop-tw-0.71.0
  • dependabot/bundler/rubocop-tw-0.72.0
  • dependabot/bundler/rubocop-tw-0.73.0
  • dependabot/bundler/rubocop-tw-0.74.0
  • dependabot/bundler/rubocop-tw-0.75.0
  • dependabot/bundler/rubocop-tw-0.76.0
  • dependabot/bundler/rubocop-tw-0.77.0
  • dependabot/bundler/rubocop-tw-0.78.0
  • dependabot/bundler/rubocop-tw-0.79.0
  • dependabot/bundler/rubocop-tw-0.80.0
  • dependabot/bundler/rubocop-tw-0.80.1
  • dependabot/bundler/rubocop-tw-0.81.0
  • master
  • v0.1.3
  • v0.2.0
  • v0.3.0
  • v1.0.0
  • v1.1.1
  • v2.0.0
  • v2.1.0
  • v2.2.0
  • v2.3.0
  • v2.4.0

pending completion
107

Pull #3

travis-ci

web-flow
Refactor into visitor and formatter

This refactors the visitor and URI template building to be faster, simpler
and easier to test. It should be easier to add explicit caching too.

The new RFC6570::Visitor only traverses the Journey AST to produces a
list of parts needed to build an URI template. It does not filter for ignored
substitutions nor append controller parameters to the part list. This
means we can run this once for a route and reuse the much simpler and faster
parts list for build customizable URI templates. The visitor uses its cached
method dispatch for dual-node CAT clauses too, simplifying the implementation.
Last but not least it got its own test suite too.

The new RFC6570::Formatter uses the part list from a visitor to build URI
templates. It filters for ignored substitutions, adds action parameters and
contains all code needed to build path only or full URI templates. It further
avoids creating templates twice when generating full URLs.
Pull Request #3: Refactor into visitor and formatter

95 of 95 new or added lines in 3 files covered. (100.0%)

161 of 168 relevant lines covered (95.83%)

367.39 hits per line

Relevant lines Covered
Build:
Build:
168 RELEVANT LINES 161 COVERED LINES
367.39 HITS PER LINE
Source Files on jg/formatter
  • List 0
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
107 jg/formatter Refactor into visitor and formatter This refactors the visitor and URI template building to be faster, simpler and easier to test. It should be easier to add explicit caching too. The new RFC6570::Visitor only traverses the Journey AST to produc... Pull #3 22 Aug 2018 01:42PM UTC web-flow travis-ci pending completion  
106 jg/formatter Refactor into visitor and formatter This refactors the visitor and URI template building to be faster, simpler and easier to test. It should be easier to add explicit caching too. The new RFC6570::Visitor only traverses the Journey AST to produc... push 22 Aug 2018 01:36PM UTC jgraichen travis-ci pending completion  
105 jg/formatter Refactor into visitor and formatter The refactors the visitor and URI template building to be faster, simpler and easier to test. It should be easier to add explicit caching too. The new RFC6570::Visitor no only traverses the Journey AST an prod... push 22 Aug 2018 01:24PM UTC jgraichen travis-ci pending completion  
104 jg/formatter Refactor into visitor and formatter The refactors the visitor and URI template building to be faster, simpler and easier to test. It should be easier to add explicit caching too. The new RFC6570::Visitor no only traverses the Journey AST an prod... push 21 Aug 2018 09:06PM UTC jgraichen travis-ci pending completion  
103 jg/formatter Refactor into visitor and formatter The refactors the visitor and URI template building to be faster, simpler and easier to test. It should be easier to add explicit caching too. The new RFC6570::Visitor no only traverses the Journey AST an prod... push 21 Aug 2018 08:08PM UTC jgraichen travis-ci pending completion  
See All Builds (254)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc