jamesfer / cypher-query-builder

98%

master: 98%

LAST BUILD ON BRANCH fix-term-list-clause-nested-dictionaries

branch: fix-term-list-clause-nested-dictionaries

CHANGE BRANCH

x

Reset

• fix-term-list-clause-nested-dictionaries
• accept-regex-in-where
• add-override-to-set-values
• add-raw-template-tag
• automatic-changelog
• build-using-rollup
• change-delete-default-behaviour
• create-merge-clause
• create-query-first-method
• create-remove-clause
• create-stream-method
• develop
• enable-sudo-in-travis
• expand-accepted-where-conditions
• expand-connection-options
• fix-code-style
• fix-documentation
• fix-gh-actions-deploy
• fix-lodash-externals
• fix-missing-build-step
• fix-missing-coveralls-data
• fix-override-set-option-documentation
• fix-promise-types
• fix-rollup-generated-imports
• fix-set-limit-type-signature
• fix-set-merge-with-primitives
• fix-where-between-error
• fix-where-clause-side-effects
• fix/bloated-package
• gh-actions
• greenkeeper/@semantic-release/git-7.0.14
• greenkeeper/@semantic-release/git-7.0.15
• greenkeeper/@semantic-release/git-7.0.16
• greenkeeper/@types/lodash-4.14.135
• greenkeeper/@types/lodash-4.14.136
• greenkeeper/@types/node-12.0.11
• greenkeeper/@types/node-12.0.12
• greenkeeper/@types/node-12.6.0
• greenkeeper/@types/node-12.6.1
• greenkeeper/initial
• greenkeeper/monorepo.babel7-20190704132520
• greenkeeper/monorepo.babel7-20190704205919
• greenkeeper/monorepo.babel7-20190704205935
• greenkeeper/monorepo.babel7-20190704205953
• greenkeeper/monorepo.babel7-20190704210015
• greenkeeper/monorepo.babel7-20190706082134
• greenkeeper/monorepo.babel7-20190708200138
• greenkeeper/monorepo.babel7-20190709152622
• greenkeeper/monorepo.babel7-20190709192312
• greenkeeper/rollup-1.16.3
• greenkeeper/rollup-1.16.4
• greenkeeper/rollup-1.16.5
• greenkeeper/rollup-1.16.6
• greenkeeper/rollup-1.16.7
• greenkeeper/semantic-release-15.13.18
• import-missing-exported-types
• improve-docker-setup
• improve-transformer
• make-error-handling-consistent
• make-where-op-abstract
• master
• new-order-by-constraint-style
• only-inline-whole-variables
• order-by
• order-by-direction-case-insensitive
• patreon-link
• peer-to-dev-dependencies
• raw-clause
• relation-labels
• remove-duplicate-tests
• remove-old-scripts
• remove-rxjs-peer-dep
• remove-set-deprecated-behaviour
• remove-where-side-effects
• run-builds-on-prs
• strict-typescript
• support-arrays-in-transformer
• support-plugable-promise-observable
• transformer-uplift
• update-dependencies
• update-node-neo4j-test-versions
• update-npm-token
• use-neo4j-integer-for-skip-limit
• use-parameters-in-skip-limit
• v1.0.0
• v1.0.1
• v1.1.0
• v1.1.1
• v1.1.2
• v2.0.0
• v3.0.0
• v3.0.1
• v3.1.0
• v3.2.0
• v3.3.1
• v3.4.0
• v3.4.1
• v4
• v6

Build # 916

Build Type

push

travis-ci

Committed by jamesfer

Commit Message

fix(termlist): fix handling of nested dictionaries

The documentation described the behaviour of `with` and `return` when given a nested set of
dictionaries:
```javascript
query.with({
  people: {
    name: 'personName',
    age: 'personAge',
  },
});
// WITH people.name AS personName, people.age AS personAge
```

However the types forbade this. If using Javascript, no error was returned, however the
result was very different to the documentation. It now behaves as documentated.

If you are using Typescript this is not a breaking change as the types would have
prevented you from using the faulty behaviour.

If you as using Javascript then there is a chance that this will change the behaviour
of your code but it is unlikely and the other behaviour is a bug.

fixes #137

Run Details

355 of 427 branches covered (83.14%)

850 of 870 relevant lines covered (97.7%)

99.43 hits per line