jakirkham / metawrap

99%

master: 100%

LAST BUILD ON BRANCH fix_python_34

branch: fix_python_34

CHANGE BRANCH

x

Reset

• fix_python_34
• config_pypi_release
• fix_pypi_deploys
• full_tst_cov
• master
• recut_cookie
• update_copyright
• v0.0.1
• v0.0.2
• versioneer_0.17

Build # 13

Build Type

push

travis-ci

Committed by jakirkham

Commit Message

Convert argument to `reversed` to a list.

Python 3.5 added support for `OrderedDict`'s `items`, `keys`, and
`values` iterator objects to be reversed by implemented `__reversed__`.
Also Python 2.7 got both of all these as `list`s, which already had
support for `__reversed__`. However, Python 3.4 had iterator objects
returned by all of these methods that did not support `__reversed__`.
Hence there were some test failures on Python 3.4 and `with_setup_state`
failed. Here we fix this by always converting the result to a `list`
regardless, which fixes the problem. More details on all of this in the
references below.

xref: https://bugs.python.org/issue19505
xref: https://docs.python.org/3/whatsnew/3.5.html#collections

Run Details

149 of 150 relevant lines covered (99.33%)

2.98 hits per line