iwaseyusuke / ryu

64%

master: 68%

LAST BUILD ON BRANCH stplib-Adopt_to_Python3

branch: stplib-Adopt_to_Python3

CHANGE BRANCH

x

Reset

• stplib-Adopt_to_Python3
• BGPSpeaker-Advertise_local_routes_to_RR_clients
• BGPSpeaker-Allow_local_as_in_count
• BGPSpeaker-Enable_to_notify_BGP_events
• BGPSpeaker-Enable_to_notify_adj-RIB-in_changed
• BGPSpeaker-Enable_to_specify_local_listen_addresses
• BGPSpeaker-Enable_to_specify_remote_port_for_neighbor
• BGPSpeaker-Enhance_APIs_for_operator_show
• BGPSpeaker-Remove_redundant_pram_to_delete_route
• BGPSpeaker-Sort_out_application_for_BGPSpeaker
• BGPSpeaker-Support_EthernetVPN
• BGPSpeaker-Support_EthernetVPN_old
• BGPSpeaker-Support_Four-Octet_AS_number
• BGPSpeaker-Support_IPv6_VPNv6
• BGPSpeaker-Support_RPC_CLI_on_Python3
• BGPSpeaker-Support_Route_Reflector_features
• BGPSpeaker-Support_VNI_for_EVPN
• BGPSpeaker-Support_to_advertise_Type_1_2_RT
• BGPSpeaker-net_ctrl-Close_activity_for_each_settion
• BGPSpeaker/net_ctrl-Close_activity_for_each_settion
• OVSDB-Add_unit_tests
• OVSDB-Extentions_for_VXLAN_tunnel
• OVSDB-Update_with_OVS_v2_5_0
• OVSDB-Update_with_OVS_v2_6_0
• PyInstaller-Enable_to_compile_executable
• app-Add_REST_EVPN_app
• app-Use_wsgi_wrappers_in_REST_Apps
• bgp_sample_conf-absolute_import_to_suppress_warnings
• bgp_scenario_test-Clean_previous_builds_before_installing
• bgp_scenario_test-Pylint
• bgp_scenario_test-Switch_Python_version
• contrib-Remove_embedded
• controller-Support_proactive_connection
• doc-Deprecate_OpenStack_plugin_ref
• doc-Deprecated_option_html_use_smartypants
• doc-Fix_unexpected_indent_in_ofctl_api_doc
• doc-Improvements_for_library_packet_ref
• doc-Update_docs_for_developers
• doc-lib-ovs
• doc-services_protocols_bgp_application
• docker_base-Update_base_image
• dpset-Fix_iteration_error_when_disconnecting_switches
• flags-Inject_class_attr_to_LooseVersion
• hub-Ommit_validation
• lib-Reduce_Pylint_warnings
• lib-hub-Workaround_for_issue_of_eventlet
• lib-ofctl-Enable_to_filter_flow_stats_by_priority
• lib-ofctl-Use_str_to_int
• lib-ovs-Move_definition_for_OVSDB_timeout
• lib-packet-tcp-Parse_option_field
• library_ovsdb_manager-Descriptions_for_OVS_configs
• manager-Catch_KeyboardInterrupt_exception
• manager-user_flags
• master
• mrtlib-Add_MRT_format_parser
• mrtlib-Support_RFC8050
• nicira_ext-Support_NSH_match
• nx_message-Export_Nicira_messages_to_ofproto_v1_2345_parser
• ofctl-Enable_to_get_all_datapath_objects
• ofp_handler-Close_socket_when_HELLO_failed
• ofproto-Fix_length_calc_of_OFPOxmId
• ofproto-Support_NSH_match
• ofproto-Support_OFPErrorExperimenterMsg
• ofproto_event-Timestamp_with_option
• ofproto_v1_5-Func_to_disable_EXT-334
• ofproto_v1_5_parser-Change_default_of_command_bucket_id
• packet-Add_VXLAN_parser
• packet-Avoid_parsing_an_empty_buffer
• packet-BGP-Support_EthernetVPN
• packet-Fix_minimum_ethernet_frame_length
• packet-Implement_json_representation
• packet-Implement_json_representation_r2
• packet-bgp-Support_multiple_next_hop
• packet-dhcp6
• packet-icmp-Avoid_TypeError_when_calculating_length
• packet-zebra-Add_Zebra_protocol_parser
• packet-zebra-IP_ROUTE_mesagge_from_Zebra
• packet-zebra-Support_FRR_version_3
• packet-zebra-Support_some_FRR_messages
• pip-Add_Cython_for_accelerating_msgpack
• pip-Move_tinyrpc_to_pip-requires
• pip-OpenStack_eventlet_requirements
• pip-OpenStack_requirements
• pip-Separate_test-requires
• pip-Specify_lxml_version
• pycodestyle-Replace_pep8
• rest_firewall-Compare_reserved_port_in_str_representation
• rest_qos-Avoid_None_when_deleting_OVSDB_addr
• rest_qos-Avoid_discarding_Queues_info
• rest_qos-Fix_to_handle_the_case_without_QoS_action
• rest_router-Fix_ARP_THA_in_reply
• rest_router-Fix_conversion_of_pktlib_to_dict
• rest_vtep-Add_some_desc_for_troubleshooting
• rpc_cli-Enable_to_execute_a_single_command
• service-ovsdb-Default_of_controller_info_in_set_controller
• stringify-Fix_to_utilise_six_builtins
• test_parser_ofpmatch-Reduce_duplicated_cases
• tests-Revert_some_test_files
• tests-Separate_tests
• tests-Separate_tests_r2
• tests-Separate_tests_r3
• topology-Enable_to_detect_migrations_of_hosts
• tox-Move_dependencies_installation_to_travis_yml
• tox-Test_ryu-manager_without_additional_requirements
• utils-Add_decorator_for_deprecated_func
• utils-Avoid_using_pip_as_library
• utils-import_module-Prefer_filepath_than_Python_module
• wsgi-Change_default_wsgi_listen_host
• zebra-Implement_Zebra_protocol_service

Build # 331

Build Type

push

travis-ci

Committed by iwaseyusuke

Commit Message

stplib: Handle the port state not changed events

According to OpenFlow Spec 1.3.5, OFPT_PORT_STATUS messages with
the reason value OFPPR_MODIFY should be sent the BOTH port state
and config have changed.
On the other hand, OVS does not send OFPT_PORT_STATUS messages
when the port config has changed and only sends when the port
state has changed.
But, other switch implementation, e.g. Lagopus, sends messages
when the both port state and config have changed.
Therefore, simple_switch_stp_13.py will overproduce the topology
recalculation events and will fail to recalculate the topology.

This patch checks the port state in OFPT_PORT_STATUS messages
and ignores the message if the port state is not changed.

Reported-by: Hong Panha <c011361065@edu.teu.ac.jp>
Signed-off-by: IWASE Yusuke <iwase.yusuke0@gmail.com>

Run Details

48146 of 74683 relevant lines covered (64.47%)

2.58 hits per line