ironsmile / nedomi

67%

master: 73%

LAST BUILD ON BRANCH circumventHttpServerTimeoutBeingDeadlineByChangingWhatConn.SetDeadlineDoes

branch: circumventHttpServerTimeoutBeingDeadlineByChangingWhatConn.SetDeadlineDoes

CHANGE BRANCH

x

Reset

• circumventHttpServerTimeoutBeingDeadlineByChangingWhatConn.SetDeadlineDoes
• accesslogSizeFix
• addLocationInfoInAccessLog
• addStackToFlexibleResponseWriterError
• additional_modules
• advanced-upstreams
• as-many-tests-as-i-can-think-of
• bad_fmt
• benchmarks/lru
• bugfix/default-upstream-host-headers
• bugfix/handlersSettingsPointingToSameUnderlyingArray
• bugfix/ironsmileLoggerLevelSetting
• bugfix/misc
• bugfix/mutex-for-storage-headers
• bugfix/original-host-header-forwarding
• bugfix/panicsFromTheScheduler
• bugfix/pidfile-cleanup
• bugfix/smartReader
• bugfix/storageLoadHardening
• bugfix/tooManyOpenFiles
• bugfix/upstream-with-basic-auth-again
• cache-related-headers
• cleanup
• cleanup-3
• cleanup-4
• cleanup-redux
• config
• configurable-makefile
• contexts
• debug_headers
• disk-refactor
• disk-restore-test
• enable_lint
• enforce_lint
• errcheck
• error_vet
• feature/CompositeError.AppendErrorNilNoop
• feature/access-log-hostname
• feature/access-log-hostname-with-unknown-location
• feature/accesslog
• feature/cacheKeyBuilding
• feature/change-log
• feature/config-parsing-error-messages
• feature/configurable-default-cache-time
• feature/consistentStatus
• feature/dirGetsStrip
• feature/disk-loading-on-restart
• feature/expire
• feature/grace
• feature/handlerChains
• feature/handlerConfigurationAndOtherRefactorings
• feature/headers-rewrite
• feature/headersRewrite
• feature/io-tranfer-size
• feature/io_min_max_settings
• feature/iterateWithSkipCacheKeyInPath
• feature/locations
• feature/logrotate-config
• feature/mp4Handler
• feature/optional-http-pprof-address
• feature/pprofHandler
• feature/purge
• feature/purge2.0
• feature/reimplementThrottle
• feature/serverStatistics
• feature/someHandlers
• feature/statusJSON
• feature/statusPageSettings
• feature/statusVersion
• feature/storage.Close
• feature/synchronizedUpstreams
• feature/upstream-redone
• feature/useSendFileSometimes
• feature/versioning
• feature/vhost-aliases
• fix/applicationLoggerNotBeingClosedAndRaces
• fix/dateHeaderCaching
• fix/deadlineFixes
• fix/dontPromoteJustAdded
• fix/headersDoubleAdd
• fix/headersNotCopyingStatus
• fix/ironsmileLogger
• fix/loggerFileLeaking
• fix/logger_std_always_newline
• fix/lruListTier
• fix/lruResizeBreakingLRU
• fix/panicInLRUWhenWeAreInconsistent
• fix/proxy-loop
• fix/proxy_balance_on_path_only
• fix/purgeNotReturningFalse
• fix/raceConditions
• fix/schedulerGetsALogger
• fix/skipReadCloserFix
• fix/testConfig
• fix/testingImport
• fix/testing_flags_leak
• fix/timerIsNotTicker
• fix/tooManyOpenFiles
• fixes/synchronizedUpstreams
• flv-fixes
• fmt_vet_changes
• generate-check
• getContextFromRequest
• go-only-generate-system
• golintChanges
• headers-readme-more-examples
• httputils
• init-refactoring
• io-workers
• jsonErrorMessages
• log_module
• logger_fix
• loggers_linting
• logsLevelChanges
• lruBenchmarks
• lruResizeDownFixes
• main-improvements
• master
• misc/errcheckHappiness
• mock
• more-upstreams
• mp4-fixes
• no-loop-orchestrator
• no-orchestrator
• noCacheKeyInPath
• notNilNextHandler
• optimizations
• optimize-reading
• optimizeGetContentsAndFriends
• orchestration
• orchestration-test-fixes
• orchestration-test-fixes-2
• orchestrator2
• partWriterShortWriteLoggedAsError
• performance_test
• proxy-handler
• proxy-retry
• purge-fixes
• readerFixes
• refactoring-removing-stutter
• refactoring/partWriter
• refactorings/useMoreHashes
• reimplementUpstreamWithClient
• release/0.1
• reload-config
• remove-via
• removeAStat
• removeCustomErrorWithStack
• request-id
• resizeDown
• response-timeouts-instead-of-deadlines
• revertDuplicateCacheZoneKeyRestriction
• rewriteDateAndTimeBasedHeaders
• rewriteTimeBasedHeaders
• schedulerReuseTimer
• spelling
• start-as-a-normal-user
• storage-disk-WIP
• storageReloadLogging
• testCleanup
• testCoverallsCoverageLogic
• tests-and-cleanup
• timeoutConnOptimization
• travis-1.5
• travisIgnoreVendored
• travisTipFailure
• upTheLimits
• upstream-basic-auth-test
• upstream-impl
• upstream-impl-fixes
• utilsCleanup
• v.0.1.1-retry
• v0.1.0
• v0.1.10
• v0.1.11
• v0.1.12
• v0.1.13
• v0.1.14
• v0.1.15
• v0.1.2
• v0.1.3
• v0.1.4
• v0.1.5
• v0.1.6
• v0.1.7
• v0.1.8
• v0.1.9

Build # 546

Build Type

push

travis-ci

Committed by MStoykov

Commit Message

change http.Server.*Timeout to be on a per Read|Write basis

This is fun feature which circumvents the fact that http.Server timeout
is not useful when you have long living connections. If you have a
connection which will have to live for 20 minutes you can either put
your timeout to something above 20 minutes and possibly have connections
which are stale for 20 minutes, have timeout connections for no good
reason or do what is done through this commit.

This commit changes the meaning of net.Conn.Set*Deadline to mean
"calculate me a timeout from now till the deadline and than use that to
deadline each Read|Write operation for that timeout", not all of them.

This means that you can have a timeout of 10 seconds and connections
which have been used to transmit data for as long as each Read|Write
takes less than 10 seconds.

This is only done for the connections served by facebook's grace - the
incoming traffic for nedomi. For this reason the grace project was ...
forked. Vendoring the gracehttp package should be considered at a future
date.

Run Details

2284 of 3389 relevant lines covered (67.39%)

4002.53 hits per line