ilyabrin / disk

78%

release: 78%

LAST BUILD ON BRANCH fix/log-request

branch: fix/log-request

CHANGE BRANCH

x

Reset

• fix/log-request
• additions-in-types
• alert-autofix-1
• alert-autofix-2
• chore/gitattributes
• ci/lint-v2
• dependabot/github_actions/actions/checkout-4
• dependabot/github_actions/actions/setup-go-4
• dependabot/github_actions/actions/setup-go-5
• dependabot/github_actions/coverallsapp/github-action-1.2.0
• dependabot/github_actions/coverallsapp/github-action-1.2.4
• dependabot/github_actions/coverallsapp/github-action-2.0.0
• dependabot/github_actions/coverallsapp/github-action-2.1.0
• dependabot/github_actions/coverallsapp/github-action-2.1.2
• dependabot/github_actions/coverallsapp/github-action-2.2.0
• dependabot/github_actions/coverallsapp/github-action-2.2.1
• dependabot/github_actions/coverallsapp/github-action-2.2.3
• dependabot/github_actions/coverallsapp/github-action-2.3.0
• dependabot/github_actions/coverallsapp/github-action-2.3.3
• dependabot/github_actions/dot-github/workflows/actions/checkout-5
• dependabot/github_actions/dot-github/workflows/actions/checkout-6
• dependabot/github_actions/dot-github/workflows/actions/checkout-7
• dependabot/github_actions/dot-github/workflows/actions/dependency-review-action-5
• dependabot/github_actions/dot-github/workflows/actions/setup-go-6
• dependabot/github_actions/dot-github/workflows/actions/setup-go-7
• dependabot/github_actions/dot-github/workflows/coverallsapp/github-action-2.3.6
• dependabot/github_actions/dot-github/workflows/coverallsapp/github-action-2.3.7
• dependabot/github_actions/dot-github/workflows/coverallsapp/github-action-2.3.8
• dependabot/github_actions/dot-github/workflows/github/codeql-action-4
• dependabot/github_actions/dot-github/workflows/securego/gosec-2.22.10
• dependabot/github_actions/dot-github/workflows/securego/gosec-2.22.11
• dependabot/github_actions/dot-github/workflows/securego/gosec-2.22.7
• dependabot/github_actions/dot-github/workflows/securego/gosec-2.22.8
• dependabot/github_actions/dot-github/workflows/securego/gosec-2.22.9
• dependabot/github_actions/dot-github/workflows/securego/gosec-2.23.0
• dependabot/github_actions/dot-github/workflows/securego/gosec-2.27.1
• dependabot/github_actions/dot-github/workflows/securego/gosec-2.28.0
• dependabot/github_actions/github-actions-38f1f72cae
• dependabot/github_actions/github-actions-541e0c332b
• dependabot/github_actions/github/codeql-action-3
• dependabot/github_actions/jandelgado/gcov2lcov-action-1.1.0
• dependabot/github_actions/jandelgado/gcov2lcov-action-1.1.1
• dependabot/go_modules/github.com/stretchr/testify-1.10.0
• dependabot/go_modules/github.com/stretchr/testify-1.11.0
• dependabot/go_modules/github.com/stretchr/testify-1.11.1
• dependabot/go_modules/github.com/stretchr/testify-1.9.0
• dependabot/go_modules/go-dependencies-37ff05d3c1
• dependabot/go_modules/gopkg.in/dnaeon/go-vcr.v3-3.2.0
• disk-rc1
• docs/community
• docs/friendly
• feature/comprehensive-improvements
• fix/transfer-timeouts
• lil-fix-readme
• new-version
• refs/tags/v1.0.1
• release
• security-checks
• tests
• tests-1
• update-readme
• v1.1.0
• v1.1.1
• v1.2.0
• v1.2.1
• v1.2.2

Build # 37535403916

Build Type

Pull #84

github

Committed by ilyabrin

Commit Message

fix: make request logging show what it says it shows

LogRequest had its branches the wrong way round. Ordinary headers such as
Content-Type were printed as "[sanitized]", while the Authorization header
was printed masked. As a side effect SanitizeAuth: false, which should log
values unchanged, hid every header instead.

The masking itself kept the first four and last two characters. For
Authorization the first four were a truncated "OAut"; for a header such as
X-Api-Key they were the start of the secret.

Ordinary headers are now logged as they are. A credential-bearing header
becomes "***", and Authorization keeps its scheme, as in "OAuth ***", so
the log still says what kind of credential was sent without showing any
of it. SanitizeAuth: false now logs values unchanged, as its name says.
Headers are sorted by name, so two runs can be compared line by line.

The masking marker stays "***", which keeps SanitizeValue's existing
contract and leaves the older logger tests passing unchanged. The new
tests fail against the previous code.

Pull Request Pull Request #84: fix: make request logging show what it says it shows

Coverage Stats

16 of 16 new or added lines in 1 file covered. (100.0%)

1919 of 2454 relevant lines covered (78.2%)

19.42 hits per line