igniterealtime / Smack
40%
master: 40%

LAST BUILD BRANCH: gh-readonly-queue/master/pr-645-2cc77b4df3be30cd30b33ea9defbda84483e0e3f
DEFAULT BRANCH: master
Repo Added
Files 1195
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH sint_syncpoint_timeoutmessage
branch: sint_syncpoint_timeoutmessage
CHANGE BRANCH
x

coverage: 39.577% (-0.001%) from 39.578%
#3098

push

github

guusdk 
[sinttest] Carry over assertion message when sync point times out

`AbstractSmackIntTest#assertResult()` takes an argument that is an assertion message. When the sync point times out, that message should be logged.

The following illustrates the change, as a result of this assertion failing:

```
assertResult(resultSyncPoint, "Expected " + conTwo.getUser() + " to receive message that was sent by " + conOne.getUser() + " in room " + mucAddress + " (but it did not).");
```

Prior to this change, this is logged:

```
SEVERE: MultiUserChatIntegrationTest.mucTest (Normal) failed: java.util.concurrent.TimeoutException: Timeout expired
java.util.concurrent.TimeoutException: Timeout expired
	at org.igniterealtime.smack.inttest.util.ResultSyncPoint.waitForResult(ResultSyncPoint.java:49)
	at org.igniterealtime.smack.inttest.AbstractSmackIntTest.assertResult(AbstractSmackIntTest.java:104)
	at org.igniterealtime.smack.inttest.AbstractSmackIntTest.assertResult(AbstractSmackIntTest.java:99)
	at org.jivesoftware.smackx.muc.MultiUserChatIntegrationTest.mucTest(MultiUserChatIntegrationTest.java:132)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	(snip)
```

With the change in this commit, that becomes:

```
SEVERE: MultiUserChatIntegrationTest.mucTest (Normal) failed: java.util.concurrent.TimeoutException: Expected smack-inttest-two-jskr4@example.org/two-jskr4 to receive message that was sent by smack-inttest-one-jskr4@example.org/one-jskr4 in room smack-inttest-message-jskr4-aud43i@conference.example.org (but it did not).
java.util.concurrent.TimeoutException: Expected smack-inttest-two-jskr4@example.org/two-jskr4 to receive message that was sent by smack-inttest-one-jskr4@example.org/one-jskr4 in room smack-inttest-message-jskr4-aud43i@conference.example.org (but it did not).
	at org.igniterealtime.smack.inttest.util.ResultSyncPoint.waitForResult(ResultSyncPoint.java:53)
	at org.igniterealtime.smack.inttest.AbstractSmackIntTest.a... (continued)

1 of 3 new or added lines in 2 files covered. (33.33%)

1 existing line in 1 file now uncovered.

16922 of 42757 relevant lines covered (39.58%)

0.4 hits per line

Relevant lines Covered
42757 RELEVANT LINES 16922 COVERED LINES
0.4 HITS PER LINE
Source Files on sint_syncpoint_timeoutmessage

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
#3098 sint_syncpoint_timeoutmessage [sinttest] Carry over assertion message when sync point times out `AbstractSmackIntTest#assertResult()` takes an argument that is an assertion message. When the sync point times out, that message should be logged. The following illustrates the c... push guusdk github
39.58
#3097 sint_syncpoint_timeoutmessage Merge 77dc527a6 into 2e94599d5 Pull #589 web-flow github
39.56
#3096 sint_syncpoint_timeoutmessage Merge b12d73c1a into 2e94599d5 Pull #589 web-flow github
39.58
#3095 sint_syncpoint_timeoutmessage [sinttest] Carry over assertion message when sync point times out `AbstractSmackIntTest#assertResult()` takes an argument that is an assertion message. When the sync point times out, that message should be logged. The following illustrates a sta... push guusdk github
39.56
See All Builds (2814)