iden3 / contracts

86%

master: 86%

LAST BUILD ON BRANCH PID-2967-simplify-get-request-params

branch: PID-2967-simplify-get-request-params

CHANGE BRANCH

x

Reset

Sync Branches

• PID-2967-simplify-get-request-params
• PID-2574-smart-contracts-test-speed-up
• PID-2701-add-issuer-id-as-output-special-signal-in-validators
• PID-2709-full-multi-query-support-on-chain
• PID-2730-support-multiple-set-on-zkp-base-contract
• PID-2817-compute-create2-address
• PID-2822-identity-trustless-issuance-with-bjj
• PID-2913-patch-hardhat-ledger
• PID-2943-fix-upgrade-safe-error
• PID-2947-identity-check-claim-existence
• PID-2960-check-v3-query-in-request-group
• PID-2964-protect-request-creation-from-front-running
• PID-2965-adjust-verification-interfaces-future-upgrades
• PID-2966-enforce-group-id-hash-request-ids
• PID-3187-fixes-verifier
• PID-3296-fix-audit-urls
• PID-3326-update-documentation-universal-verifier-v2
• PID-3346-auth-validator-without-auth-proof-verification
• PID-336-final-audit-fixes
• PID-3392-deploy-contracts-billions-mainnet
• add-audit-report
• artifacts/universal-1.0.2
• aurora-universal-verifier-deployment
• bug/genesis
• chore/PID-1175-fix-audit-notes
• chore/PID-1940-eliminate-openzeppelin-v4-dependency
• chore/PID-535-fixes-contract-re-audit
• chore/add-hex-for-sepolia-network
• chore/add-methods-to-state-migration
• chore/add-missing-deployment-artifacts
• chore/add-namespaced-storage-layout
• chore/add-usd-price-reporting
• chore/audit-fixed-2
• chore/bring-legacy-signing-address-from-v2
• chore/bump-contract-version
• chore/bump-v-2-4-2
• chore/cleanup
• chore/deploy-resubmit-uv-test-wrapper
• chore/deploy-support
• chore/deploy-tryagain-bali-03
• chore/disable-legacy-signing-address
• chore/fix-js-prettier
• chore/fixed-oz-version
• chore/iden-725-security-and-ci-settings
• chore/many-responses-for-user
• chore/many-responses-for-user-2
• chore/namespaced-storage-layout-to-naming-conventions
• chore/remove-many-states-same-block-restriction
• chore/rename-libs-and-methods
• chore/reorg-validator-contracts-inheritance
• chore/research-universal-registry-updates
• chore/research-universal-registry-updates2
• chore/set-payment-value-zkme
• chore/set-payment-value-zkme-amoy
• chore/simplify-deployment-ignition
• chore/simplify-deployment-ignition-deploy-system
• chore/simplify-deployment-ignition-recover-journal
• chore/simplify-deployment-ignition-recover-journal-upgrade-contracts
• chore/simplify-deployment-ignition-review
• chore/upgrade-openzeppelin-contracts
• chore/upgrade-to-ethers-v6
• dependabot/go_modules/test/poseidon/vectorsGen/golang.org/x/crypto-0.1.0
• dependabot/go_modules/test/poseidon/vectorsGen/golang.org/x/crypto-0.17.0
• dependabot/go_modules/test/poseidon/vectorsGen/golang.org/x/sys-0.1.0
• dependabot/go_modules/test/poseidon/vectorsGen/gopkg.in/yaml.v3-3.0.0
• dependabot/npm_and_yarn/axios-1.7.4
• dependabot/npm_and_yarn/braces-3.0.3
• dependabot/npm_and_yarn/micromatch-4.0.8
• dependabot/npm_and_yarn/openzeppelin/contracts-4.8.3
• dependabot/npm_and_yarn/openzeppelin/contracts-4.9.1
• dependabot/npm_and_yarn/openzeppelin/contracts-4.9.2
• dependabot/npm_and_yarn/openzeppelin/contracts-upgradeable-4.8.2
• dependabot/npm_and_yarn/openzeppelin/contracts-upgradeable-4.8.3
• dependabot/npm_and_yarn/openzeppelin/contracts-upgradeable-4.9.1
• dependabot/npm_and_yarn/openzeppelin/contracts-upgradeable-4.9.2
• dependabot/npm_and_yarn/secp256k1-4.0.4
• discussion-PID-2709-full-multi-query-support-on-chain
• docs/add-contract-addresses
• draft/support-anon-aadhaar-self-issuing
• feat/artifacts-21000
• feat/base-mc-payment-deploy
• feat/base-mc-payment-deploy-artifacts
• feat/create2
• feat/deploy-21001
• feat/erc-20-payment
• feat/mc-payment-erc-20-withdraw
• feat/multichain-payment
• feat/payment-deployment
• feat/privad-gist-check
• feat/privado-chain-validator-revocation
• feat/set-payment-synaps-kyc
• feat/sponsor-payment
• feat/vc-payment
• feat/verifier-payment
• feature/2.0.0-beta.0
• feature/ID-306-convert-msg-sender-to-id
• feature/PID-1152-low-level-calls
• feature/PID-1152-universal-verifier
• feature/PID-1351-ethereum-based-identities-zkp
• feature/PID-230-update-state-v2-contract
• feature/PID-2714-optional-verifers-auth
• feature/PID-2720-Implement-LinkedMultiQuery-validator
• feature/PID-2720-linked-multi-query-part2
• feature/PID-529-state-data-model-migration
• feature/PID-955-onchain-identity-tree-store
• feature/add-authV2-validator
• feature/add-convertAddressToUint256-to-utils
• feature/add-hardhat-contract-sizer
• feature/add-iidentifiable-interface
• feature/add-poseidon4-deployment
• feature/add-resolver-interface
• feature/add-validator-version
• feature/add-w3c-credential-library
• feature/add-zk-evm-id-type
• feature/amoy
• feature/artifacts
• feature/billions-testnet-deployment
• feature/check-id-types-multi-chain
• feature/check-old-universal-verifier
• feature/check-unified-contracts
• feature/check-universal-verifier-multi-chain
• feature/claim-builder-tests
• feature/claimPathNotExists
• feature/common-interface-for-uv-and-zk-verifier
• feature/deploy-onchain-tree-store
• feature/deploy-poseidon
• feature/deploy-uv-and-mc-payment
• feature/deployments
• feature/deployments-workarounds
• feature/deployments-zkevm
• feature/embedded-verifier-v2-override
• feature/extend-IstateInterface
• feature/flex-type-id
• feature/groth16-verifiers-remove-create2
• feature/hardhat-update
• feature/improve-timestamps-checks
• feature/increase-npm-version
• feature/is-genesis-state-test
• feature/legacy-signing-address-cross-chain
• feature/lib-solhint
• feature/lite-state
• feature/lite-state-deployment-scripts
• feature/lite-state-deployments
• feature/lite-state-improve-config
• feature/lite-state-improve-deploy-scripts
• feature/lite-state-more-tests
• feature/lite-state-requestId-uint64
• feature/lite-state-review-fixes2
• feature/lite-state-unified-addresses
• feature/lite-state-unit-tests
• feature/lite-state-upgrade-chains
• feature/lite-state-with-selective-disclosure
• feature/lite-state-with-sponge-poseidon-for-selective-disclosure
• feature/maintenance-multi-network-block-timestamp
• feature/max-depth-param-in-smt
• feature/new_deployments
• feature/onchain-genesis-vectors-fix
• feature/onchain-identity
• feature/onchain-identity-cred-status-interface
• feature/onchain-identity-default-id-type-changes
• feature/onchain-identity-fix-idCalc
• feature/onchain-identity-generic-state-transition
• feature/onchain-identity-idTypeInitialized
• feature/onchain-identity-merge
• feature/onchain-identity-move-examples
• feature/onchain-identity-networkPrefix
• feature/onchain-identity-reinitializer
• feature/onchain-identity-review
• feature/onchain-identity-review-2
• feature/onchain-non-merklized-issuer-lib
• feature/pid-1054
• feature/pid-530-migration-scripts
• feature/pid-695
• feature/pid-809
• feature/polygon-state-upgrades
• feature/primitive-utils
• feature/privado-2.5.0
• feature/privado-deployments
• feature/proxy-disable
• feature/refactor-zkp-validators
• feature/remove-ignition
• feature/return-proof-with-states
• feature/set-oracle-signing-address
• feature/set-zkme-payment-request
• feature/split-deployment-scripts
• feature/state-contract-versioning
• feature/support-display-method-for-onchain-non-merklized-issuer
• feature/transparent-payment-demo
• feature/unifersal-verifier-as-public-service
• feature/update-natspec
• feature/update-readme
• feature/upgrade-2.3.0
• feature/upgrade-artifcats
• feature/upgrade-check-bytecode
• feature/upgrade-framework
• feature/v3-validator
• feature/validator-beta-1
• feature/validator-set-state-addr
• feature/verify-deployments-etherscan
• feauture/verifier-snarkjs-0.7.0
• fix-packages-vulnerabilities
• fix/PID-2704-bugs-in-overridden-methods-of-universal-verifier
• fix/PID-2879-payment-audit
• fix/PID-2879-payment-audit-deployment-artifacts
• fix/PID-2879-payment-audit-deployment-artifacts-strange
• fix/PID-2962-lmk-proof-link-id-not-zero
• fix/add-supportsInterface-function-to-identitybase
• fix/add-version
• fix/audit-permit-frontrunning
• fix/base-validator-simplify
• fix/billions-network-settings
• fix/block-timestamp-unsync
• fix/bump-v
• fix/check-unified-contracts
• fix/check-universal-verifier-single-network
• fix/ci
• fix/deploy-scripts-for-basic-strategy
• fix/deployment-proxy-implementation
• fix/disable-proxy-contract-script
• fix/embedded-verifier-v2-contracts-version
• fix/fix-genesis-state
• fix/hardhat-update-version
• fix/hide-update-req-in-base
• fix/hotfix-its-deployment
• fix/idcore-34
• fix/idtype-fix
• fix/iterate-version-v3-fix
• fix/izkpverifier-interface
• fix/linked-proofs-v3
• fix/mc-payment-audit
• fix/mc-payment-pay-erc20-expiration-check
• fix/mc-payment-recipient
• fix/mcpayment-done
• fix/npm-vulnerabilities
• fix/onchain-identity-id-based-on-nonce-test
• fix/proof-type
• fix/publish-ci
• fix/release-stabilisation-fixes
• fix/remove-excessive-length-check
• fix/reuse-common-code
• fix/same-convert-from-to
• fix/set-id-type-script
• fix/state-provide-cross-chain-address
• fix/stateV2-file-rename
• fix/temp-update-request
• fix/universal-veriferi-version-in-constants
• fix/universal-verifier-create2-lib
• fix/upgrade-embedded-verifier-script
• fix/upgrade-scripts
• fix/verifier-id-check
• fix/virtual-initializer
• fix/wrong-utils-import
• fix/zkp-verifier-get-proof-status
• hotfix/constant-proxy-bytecode
• hotfix/constant-proxy-bytecode-all-contracts
• hotfix/correct-validator-versions-and-addresses
• hotfix/disable-proxy-contract
• hotfix/readme-hotfix
• hotfix/rollback-state-to-the-prev-version
• hotfix/set-proof-request-script
• master
• pid-808
• poc/linea-sepolia
• refs/heads/feature/pid-809
• refs/heads/master
• refs/heads/vmidyllic-patch-1
• refs/tags/state-2.3.0
• refs/tags/state-v2.2.0
• refs/tags/state-v2.3.0
• refs/tags/state-v2.4.0
• refs/tags/state-v2.4.1
• refs/tags/state-v2.6.1
• refs/tags/v1.0.0-beta.0
• refs/tags/v2.5.7
• rename/v3-beta
• rename/v3-beta-version
• test/deploy-universal-verifier-v3
• update-ci
• upgrade-state-2.5.0
• upgrade/2.4.1
• upgrade/stateV2-default-id-type
• v2
• v3
• vmidyllic-patch-1

Build # 13940224012

Build Type

Pull #350

github

Committed by daveroga

Commit Message

fix solhint

Pull Request Pull Request #350: Audit: Simplify getRequestParams + setRequests front-running protection

Run Details

540 of 720 branches covered (75.0%)

Branch coverage included in aggregate %.

21 of 26 new or added lines in 6 files covered. (80.77%)

2 existing lines in 2 files now uncovered.

1349 of 1484 relevant lines covered (90.9%)

40.24 hits per line