iTowns / itowns

65%

master: 88%

LAST BUILD ON BRANCH 1283-delete-geometry-layer

branch: 1283-delete-geometry-layer

CHANGE BRANCH

x

Reset

• 1283-delete-geometry-layer
• 1106-flying-buildings
• 1333-fix
• 2.12.0
• 2.14.0
• 2.15.1
• 2.15.2
• 2.15.3
• 2.17.0
• 2.18.0
• 2.19.0
• 2.26.0
• 2.27.0
• 2.28.0
• 2.31.0
• 2.32
• 2.4.2
• 20065
• 2486-wrong-terrain-tiles
• 25dexample
• 2WebGL2
• 3d-tiles-migration
• 3d-tiles-renderer-v1
• 3d-tiles/pick-metadata
• 3d_tiles_overide_material
• 3dt_material
• 3dtile_source
• 3dtiles-debug-fix
• 3dtiles_refactoring-rebase
• 81-ctrl-left-click-iframe
• 835-planar-controls
• 888-travis-windows
• 942-url-builder
• DMS_coordinates
• FileSourcePreLoading
• Interactive_style
• MNS
• ModifReadCRS
• PrepWorkers
• Style_circle
• VeinKowal-guoweiyu
• WIP_fix_gc
• actionGithub
• add-enable-planarcontrols-globecontrols
• add-label-to-examples
• add_alti
• add_carto_wfs
• add_debug_to_all_examples
• add_publiccode
• all_whenReady_in_source
• allow-deferred-style-property-definition
• allow-useless-constructor
• animation_damping
• api-to-plug-on-the-request-event
• applymat4
• avoid_geocentric_extent
• babel/update-targets
• babel_target
• bathy
• better-cache
• bugfix_doc
• bump
• bump/3d-tiles-renderer-0.44
• bump/copc
• bump/dec23
• bump/jun24
• bypass_index_page
• c3DTilesStyleBatchID
• c3dengine-es6
• c3dtile_process
• cache
• cache_source
• cb_addcontent
• cdn/jsdelivr
• change-dragndrop-legend
• change-wfs25d-stream
• chore-integration
• chore-rm-globecontrols-deprecated
• chore-widgets
• chore/CodeQL
• chore/bump-dev-deps
• chore/commit-message-checker
• chore/contributing
• chore/contributors
• chore/dont-watch-git-update
• chore/fix-dependencies
• chore/integration
• chore/modules_clean
• chore/node-update
• chore/npm-provenance
• chore/patch
• chore/provenance
• chore/release
• chore/unit-test
• chore/unminified-build
• chore/update-packages
• chore/workflow/update-dependencies
• ci/cleanup
• class_features
• class_gc
• class_planar_controls
• classi
• classification_clean
• classify_CCW
• clean
• clean/bump
• clean/config
• clean_alti
• clean_deprecated
• clean_gc
• clean_label
• clean_oriented_image
• clean_raster_process
• clean_source_error
• cleanup/layer
• cleanup/lil-gui
• contour
• controls
• conventions_pr
• corrEmptyStyle
• correct-pickfeaturesat-documentation
• createRelease
• crs-wkt
• css-z-index
• cursorShape
• custom-adaptive-points-parameters
• custom-points-shapes
• dat2lilGui
• debug_babel
• deepScan_fix
• deepscan
• def_crs
• demutils-getelevation
• dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7
• dependabot/npm_and_yarn/acorn-6.4.1
• dependabot/npm_and_yarn/async-2.6.4
• dependabot/npm_and_yarn/babel/runtime-7.26.10
• dependabot/npm_and_yarn/babel/traverse-7.23.2
• dependabot/npm_and_yarn/bl-4.0.3
• dependabot/npm_and_yarn/braces-3.0.3
• dependabot/npm_and_yarn/dns-packet-5.4.0
• dependabot/npm_and_yarn/elliptic-6.5.3
• dependabot/npm_and_yarn/express-4.19.2
• dependabot/npm_and_yarn/express-4.21.0
• dependabot/npm_and_yarn/follow-redirects-1.14.8
• dependabot/npm_and_yarn/follow-redirects-1.15.4
• dependabot/npm_and_yarn/follow-redirects-1.15.6
• dependabot/npm_and_yarn/handlebars-4.5.3
• dependabot/npm_and_yarn/http-proxy-middleware-2.0.9
• dependabot/npm_and_yarn/ini-1.3.7
• dependabot/npm_and_yarn/ip-1.1.9
• dependabot/npm_and_yarn/js-yaml-4.1.1
• dependabot/npm_and_yarn/loader-utils-2.0.3
• dependabot/npm_and_yarn/loader-utils-2.0.4
• dependabot/npm_and_yarn/lodash-4.17.19
• dependabot/npm_and_yarn/marked-2.0.0
• dependabot/npm_and_yarn/marked-4.0.10
• dependabot/npm_and_yarn/minimist-1.2.6
• dependabot/npm_and_yarn/multi-9423f4c335
• dependabot/npm_and_yarn/multi-96c788614a
• dependabot/npm_and_yarn/multi-9f37c16f8f
• dependabot/npm_and_yarn/multi-cd5fdbacd0
• dependabot/npm_and_yarn/multi-cf87d80143
• dependabot/npm_and_yarn/multi-d66d039ac5
• dependabot/npm_and_yarn/nanoid-3.3.8
• dependabot/npm_and_yarn/node-fetch-2.6.1
• dependabot/npm_and_yarn/node-fetch-2.6.7
• dependabot/npm_and_yarn/node-forge-1.3.0
• dependabot/npm_and_yarn/node-forge-1.3.2
• dependabot/npm_and_yarn/node-forge-1.3.3
• dependabot/npm_and_yarn/shelljs-0.8.5
• dependabot/npm_and_yarn/tar-fs-3.0.9
• dependabot/npm_and_yarn/tar-fs-3.1.1
• dependabot/npm_and_yarn/terser-5.14.2
• dependabot/npm_and_yarn/trim-off-newlines-1.0.3
• dependabot/npm_and_yarn/undici-7.2.3
• dependabot/npm_and_yarn/undici-7.5.0
• dependabot/npm_and_yarn/webpack-5.76.0
• dependabot/npm_and_yarn/webpack-5.94.0
• dependabot/npm_and_yarn/webpack-dev-middleware-5.3.4
• dependabot/npm_and_yarn/webpack-dev-server-5.2.1
• dependabot/npm_and_yarn/websocket-extensions-0.1.4
• dependabot/npm_and_yarn/word-wrap-1.2.5
• deploy
• deprec_quaternion_THREE
• deprecation/webgl1
• deps/remove-old-polyfill
• disatnce
• discard-invisible-square-points
• doc-code-to-quote
• doc-css-fix
• doc-featureGeometryLayer
• doc-layer-source
• doc-tutorial-images
• doc-tutorial-update
• doc/3d-tiles
• doc/stricter-jsdoc
• doc_update
• docs-events
• docs/run-locally
• docs/tutorials
• down_three
• drag-n-drop
• dynamic-near-far
• dynamic-style-update
• ecma_2022
• ecole-vt-icons
• entwine-point-tile
• entwineAlaVolee
• es6-coordinates
• es6-crs
• es6-view
• event
• exact_minMax_elevation
• exagerated-geoid
• example-3dtileBasic-url
• example-compass
• example-custom-controls
• example-geojson-raster
• example-minimap
• example-minimap-widget
• example-navigation
• example-potree
• example-potree-fix
• example-vector-tile-dragndrop
• example-vector-tiles
• example-widget-minimap
• example-widget-navigation-planar
• example-widget-scale
• example-widget-search
• example-widgets
• example/copc3dLoader
• example/vpc3dLoader
• example_multipolygon
• examples-FileSource
• examples-clean-js
• examples-enable-label-vector-tiles
• examples-fix-css
• examples-view-source
• examples/3dtiles-planar
• examples/camera-animation
• export_feature
• expose-Widget-class-in-api
• extent-tests
• extent-without-float64array
• extent_dimension_crs
• extent_feature
• extent_texture
• f/add-gamma-ambient-point-cloud-styling
• f/add-tsc-for-types-generation
• f/fix-dynamic-camera-near-far
• f/fix-geotiff
• f/fix-picking-null-geometry
• f/fix-pointcloud-picking
• factorize_featureTo
• fctAsStyle
• feat-getCurrentMaxZoom-infoLayer
• feat-mapbox-style-symbol
• feat-outside-div
• feat-style-complex-text-field
• feat-style-css-html
• feat-style-steps
• feat/add-ktx2-loader
• feat/add-state-controls
• feat/add-vr-event
• feat/binary-batch-table
• feat/camera-utils-bbox
• feat/cesium-ion
• feat/cog
• feat/elevation-measure
• feat/globe-view-controls-options
• feat/google3dTile-example
• feat/google3dTiles
• feat/hide-skirt
• feat/https-start-script
• feat/map-3d-extent
• feat/meshopt-api
• feat/sousterrain
• feat/sousterrain_potential_rb
• feat/update-deps
• feat/vr-controllers-for-mr
• feat/wmts-crs-string
• feat2Mesh
• featLayer
• feat_cache
• feat_orientation_parser_conv_meridian2
• feat_orientation_parser_conv_meridian3
• feat_orientedImage
• feature-dom-label
• feature-label-anchor
• feature-points
• feature-style-icon
• feature-tooltip-stream
• feature-view-coordinates
• feature-wmts-tilematrix
• feature/add-bboxUrlPrecision
• feature/add-cog
• feature/demo
• featureMatrix
• feature_mesh_properties
• feature_process
• features
• fetch_all_in_source
• file-source-layerupdatestate
• fill_pattern
• filtering_extent
• filtrePoint
• fix-1381-circular-dependency
• fix-2.24.1
• fix-3DTilesLayer
• fix-3DTilesLayer-update-style
• fix-C3DTfeatures-init
• fix-CameraUtils
• fix-Label-display
• fix-LayeredMaterialNodeProcessing
• fix-black-screen
• fix-build-test
• fix-c3DEngine
• fix-cog
• fix-colorLayer-opacity
• fix-colorLayer-shader
• fix-coord-tms
• fix-coordiates-rounding
• fix-crs-feature-utils
• fix-debug-coordinates
• fix-dispose-rastertile
• fix-doc-ellipsoid
• fix-doc-geometrylayer
• fix-doc-scroll
• fix-dom-picking
• fix-elevation
• fix-elevation-geoid
• fix-elevation-mime
• fix-ept-simple-loader
• fix-examples
• fix-examples-css
• fix-feature-parameters
• fix-featureToolTip
• fix-firstPersonControls-contextmenu
• fix-format-source
• fix-geojson-multipoint
• fix-geojson-properties
• fix-geojson-visual-issues
• fix-kml-example
• fix-label
• fix-label-div
• fix-label-layer-as-single
• fix-label-occlusion
• fix-label-position
• fix-labeldiv-size
• fix-layered-material-visible-state
• fix-line-feature2texture
• fix-min-max-zoom
• fix-network-options
• fix-ortho-zoom
• fix-picking-nan
• fix-picking-polygons
• fix-planacontrols-mouseposition
• fix-planar-focus
• fix-planar-multitouch
• fix-planar-pan
• fix-pointpos-reference
• fix-potree2-sample-data
• fix-remove-labellayer
• fix-remove-layer
• fix-remove-new-extent
• fix-resize
• fix-resize-dispose-Core-View
• fix-security-npm
• fix-shapefile-parser
• fix-style-anchor
• fix-style-offset
• fix-tilemesh-getcoord
• fix-update-style-C3DTilesLayer
• fix-vector-tile-2d-example
• fix-vector-tile-picking
• fix-vector-tile-priority
• fix-vector-tile-source-minzoom
• fix-vector-tile-style-picking
• fix-vectortile-symbol-circle
• fix-view-eventtoviewcoords
• fix-view-pickCoordinates
• fix-wfs-wms-wmts-url-params
• fix-wrong-extent-center
• fix-zoom-factor
• fix/1931-crontols-event-scope
• fix/1947-3d-tiles-cache-cleanup-rebased
• fix/1954-3dtiles-basic
• fix/2003-picking
• fix/2074-3dtiles
• fix/2159-correct-tile-when-no-terrain
• fix/2221-terrain-rm
• fix/2227-unreachable-host
• fix/2262-pointcloud-errors
• fix/2292-zoom-level-mvt
• fix/2357-hide-skirt-at-init
• fix/2426-multiple-views-3dtiles
• fix/2434-get-instance-info
• fix/2574-multiple-3dtiles
• fix/3DT-classification
• fix/3d-tiles-name
• fix/3d-tiles/example-pbr
• fix/3dtiles-bbox
• fix/3dtiles-pnts-layer-prop
• fix/3dtiles-refer
• fix/3dtiles-support-2
• fix/ElevationRange
• fix/GEO-18291-3dtiles-mel
• fix/TileLayerOpacity2
• fix/babel-deps
• fix/camera-distance-initial-pc-placement
• fix/cesium-ion
• fix/ci-release
• fix/clipping-point-cloud
• fix/cog-parser
• fix/coverage
• fix/depth-transparency
• fix/dispose
• fix/doc
• fix/docs
• fix/elevation-raster-tile
• fix/error
• fix/etpLoadOctree
• fix/example-ept
• fix/example/3dTiles
• fix/examples
• fix/examples-three-addons
• fix/issue/2236-fix-effect-type
• fix/las-cdn
• fix/las14-classification
• fix/material
• fix/missing-dat-import
• fix/package-lock
• fix/partial-loading
• fix/picking
• fix/pointcloud
• fix/pointcloud-elevation
• fix/potree-url
• fix/potree2-hierarchy
• fix/presse-ogc3dtiles
• fix/presse-pointcloud
• fix/publish_npm
• fix/remove-circular-dependency
• fix/resize-update
• fix/srtm
• fix/subdivide-hackathon
• fix/terrain-zmin-quick-zoom
• fix/test
• fix/test-node21
• fix/tileLayerOpacity
• fix/tilelayer-opacity
• fix/ts-monorepo
• fix/tutorials
• fix/typedoc-error
• fix/use-correct-getter-interleaved-buffer
• fix/use-wms-axisorder-param
• fix/webpack-watchers
• fix/wms-version-axis-order
• fix/wmts-url
• fix/xbil-parser
• fix/yarn-workspaces
• fix/zoom-state
• fix3DTriangulation
• fixBaseAlti
• fixCIfunctional
• fixElevationCOPC
• fixGUIPointCloud
• fixPotree2Brotli
• fixPotreeDebug
• fixPrecision
• fixTestGpx
• fixTestVPC
• fixTransparence
• fixVTStyleIGN
• fixVectorTileSprite
• fix_3dtiles
• fix_567
• fix_Gb_Ctrl
• fix_Node15
• fix_OIs
• fix_area_clockwise
• fix_b3dmParser_RTC
• fix_cache
• fix_camera_utils_heading
• fix_cleaning
• fix_dat_gui
• fix_debug_gui
• fix_doc_horizontal_scroll
• fix_ellipsoid
• fix_ex_wfs
• fix_extent
• fix_extent_applyMatrix4
• fix_extent_transfo
• fix_feat2Texture
• fix_featToolsTips
• fix_features
• fix_fetch_option
• fix_focus
• fix_fx
• fix_geoid
• fix_glsl
• fix_haselevation
• fix_helper_3dtiles
• fix_immersive
• fix_label_renderer
• fix_label_vis
• fix_mg
• fix_min_max_alti_25d_example
• fix_minimap_focus
• fix_node_support
• fix_node_test
• fix_npm
• fix_orientedImage
• fix_ortho_zoom
• fix_picking
• fix_planarControls
• fix_planarControls_refactoring
• fix_planar_controls_keys
• fix_planar_layer
• fix_planar_view
• fix_point_example
• fix_potree_picking
• fix_race_condition_examples
• fix_raster_elevation_process
• fix_relastic_atmo
• fix_remove_label_layer
• fix_remove_layer
• fix_rendering
• fix_scale
• fix_split
• fix_style
• fix_test_potree2
• fix_test_style
• fix_tests2
• fix_three_warning
• fix_tiledLayer_options
• fix_tms_projection_crs
• fix_tuto
• fix_unit_test_potree2
• fix_utest_gc
• fix_vt_style_cache
• fix_wfs
• fog
• foggy-point-cloud
• fusionGetStyle
• fx_deploy
• gchoqueux-patch-1
• geo_key
• geojson-unit-test
• geop_vt
• geospatial
• handle-nodatavalue-demutils
• handling_no_data_source
• hide-label-on-layer-hidden
• hor_culling
• iconStyle
• immersive-fix-gui
• instancing
• interactive_examples
• issue-1847-ColorLayers
• issue-1877-3dtiles-example-url
• issue-1883-url
• issue-1894-deployment$
• jailln-governance
• jailln-patch-1
• jsdoc_template
• key_service
• key_url
• label--delete-fix
• label-bugs-1473
• label-height-and-position2
• label-multiple-layers
• label-vector-tile
• label_doc
• label_renderer
• larger_cloud_picking
• lasParser
• layer-choice
• layer_example
• layer_state
• layered-material-typescript
• laz-parser
• link_structure
• lruCache
• mainloop
• mapBoxVT
• mapLib
• mapbox_style
• mars_itowns
• master
• material_layer
• maxminLayer
• mbredif-contributor
• merge-style-html
• migrate/coverage
• migrate/esm
• migrate/workers
• migrationGeoPF
• move-ellipsoid-size
• moveStylePattern
• move_obb
• multiSource
• mvt_ccw
• mvt_style_parent
• new-example-index
• new_release
• noDataValue
• nodata_elevation
• npm
• onWindowsFixPath
• optimize_elevation_update
• optional-light
• orientUtils
• ortho
• orthographic_camera
• pack
• padding
• paris_zoom_20
• patch
• patch-1
• patch_picking
• perf/read-image
• pickFeatureAt
• pickGeometry
• pick_feature
• pick_points_example
• picking-improve
• pickobjectat
• pickpositionCorrection
• planar-3dtiles-v2
• planarOpt
• planar_controls_implementation
• pointCloudAttributes
• pointLayer
• point_oriented_image
• point_refactor
• pointcloud-basis
• pointcloud-intensity-range
• points
• poleColor
• poles
• potree-progressive-typo
• potree2
• prefer_export_ts
• prepAlaVolee
• priorityQueue
• private_buffer
• proj_to_crs
• proxy
• ptCloudNode
• ptCloudReproj
• puppetter_waitFor_deprecated
• qb/copc
• qb/issue/2232-pointcloud-ortho
• r2.24.0
• r2.25.0
• rasterLayer
• raster_elvation_event
• raster_layer
• rawDataElevation
• readme/discord-badge
• refa_getlayerbyid
• refact_feat
• refacto-controls
• refacto-controls-keyboard
• refacto-controls-wheel
• refacto-extent-ispointinside
• refacto-features
• refacto-stateControls
• refacto-style-get-anchor-position
• refacto-style-outline
• refacto-threejsLayer
• refacto-widget-navigation
• refacto/simple_loading_tile
• refacto/split-extent
• refacto/worker
• refactoReproj
• refacto_camera
• refacto_dataSourceProvider
• refacto_data_providing
• refacto_feature
• refacto_source
• refactor-example-title
• refactor-layerupdatestate
• refactorPotreeNode
• refactorPtCloud
• refactor_FEATURE
• refactor_cleanup
• refactor_crs
• refactor_obbhelper
• refactor_parser_cam_calib
• refactor_source_provider
• refactor_tileBuilder
• refactoring_parsing_options
• refs/heads/master
• relativeUrl
• release
• release_2.37
• release_v2.11.0
• remove-coords-to-extent
• remove-create-layer
• remove-create-layer2
• remove-feature-reference
• remove-instanceof
• remove-layer-source-deprecation
• remove-utif
• remove/layer-assign
• remove/webgl1
• remove_breaking_change
• remove_c_4326
• remove_lopocs
• remove_threejs_layer
• remove_up_projmat
• remove_useless_comments
• rename-collection-feature-geometries
• renameParsedData
• reorgFunctionalTests
• replace-deprecated-layers
• reworkStyle
• reworkTestFunctional
• reworkView
• rig
• rm_deploy
• rm_feat_command
• rm_source_fct
• rtc_from_FT
• rules
• scale
• segments
• setBaseAltiVT
• set_camera_frustrum
• shape
• shp-metadata
• simplify-examples
• simplify_normals
• source-testing
• source_error
• speedup-globecontrols
• stop-label-renderer
• streetcontrols
• stroke_text_label
• style
• style-doc-default-value
• style-icon-onload
• style-inheritance
• style-label-fix-sprite
• style-parser-param
• style-pattern-fix
• styleOptionsAsFile
• style_vector_tiles
• style_vt
• subpackages
• subpackages-geography
• sunLight
• suppLayerInPtcNode
• suppMVTfix
• suppStyle
• templates-update
• test-elevation-measure
• test-mock-domelement
• test-unit-describe-section
• test/page-reset
• testMaster
• test_data
• test_unit
• test_unit_boot
• test_view
• testing-hint-for-development
• testunit_Refact
• three-153
• three_v105.2
• three_v106
• three_warning
• tiff-parser
• tile_builder_typescript
• tile_event_visible
• tilemesh-refreshmaterial
• tms
• toto
• travis_fix
• treeshaking/geographic
• ts-migration/coords
• ts-migration/crs
• ts-migration/eslint
• ts-migration/eslint-max-len
• ts-migration/extent
• ts-migration/geographic
• ts-migration/pointcloud
• ts-migration/source
• ts-migration/tiled
• ts/globals-and-glsl
• ts/start
• tsc-alias
• tutorial-fixes
• typescript-defs
• typo
• typo_geoid
• uniformize-materials
• uniformize/points
• unit-test-emit-event
• unit-test-no-null-extent
• unit_laz
• unloaded-tex-bug
• up
• up_npm
• up_pack
• up_pack_npm
• up_package
• up_packages
• up_packs
• up_three
• up_threejs
• upd
• update-3d-tiles
• update-3d-tiles-renderer
• update-contributing
• update-doc
• update-doc-style
• update-proj4-geocent
• update-readme
• updatePack
• update_node_ci
• update_node_ci_test_publish
• update_packages
• update_style
• upgradeProj4_2.19.3
• url-search-param
• url_mapbox
• useContextForAllConvert
• use_baseuri
• v2.10.0
• v2.11.0
• v2.11.1
• v2.12.0
• v2.13.0
• v2.13.1
• v2.14.0
• v2.15.0
• v2.15.1
• v2.15.2
• v2.15.3
• v2.16.0
• v2.17.0
• v2.18.0
• v2.19.0
• v2.20.0
• v2.21.0
• v2.22.0
• v2.23.0
• v2.24.0
• v2.24.1
• v2.24.2
• v2.24.3
• v2.25.0
• v2.27.0
• v2.28.0
• v2.28.1
• v2.4.3
• vectorTileLayer-style
• vectortilessource
• visible_elevation
• vpcLayer
• vr-array-tex-incompatibility
• vrt-reader
• vt_extent
• vt_max_level
• webXR
• webgl2_doc
• webinar
• webpack4
• webpack5
• wheel-event-update
• wmts_tileMatrix
• workOnBaseAlti
• workflow/separate-jobs
• zoom_clean
• zoom_clean_precise

Build # 1193

Build Type

Pull #1284

travis-ci-com

Committed by web-flow

Commit Message

fix(core): remove objects of a GeometryLayer from the Scene

The property object3d (an instance of THREE.Object3D, most of the time
THREE.Group) was not correctly removed for a GeometryLayer, when calling
View#removeLayer.

Now, if the layer is a geometry one, the GeometryLayer#delete method is
called once more, and should remove the object3d property from its
parent (usually a THREE.Scene).

Pull Request Pull Request #1284: fix(core): remove objects of a GeometryLayer from the Scene

Run Details

2172 of 3784 branches covered (57.4%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

4514 of 6435 relevant lines covered (70.15%)

197.99 hits per line