hypothesis / h
70%
master: 97%

LAST BUILD BRANCH: realtime-update-v1-h-only-1
DEFAULT BRANCH: master
Repo Added
Files 34
Badge
Embed â–¾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH decouple_app_template_from_pyramid
branch: decouple_app_template_from_pyramid
CHANGE BRANCH
x

9898

push

travis-ci

robertknight 
Decouple sidebar HTML and embed JS template from webassets and Pyramid

To enable building of the extension and client app without needing
to set up the website, remove all dependencies of the sidebar HTML
and embed JS rendering from Pyramid

 * Extract rendering of the client assets into a separate module
   with no Pyramid dependencies

 * Replace the use of the webassets 'assets' Jinja2 extension and
   references to Pyramid objects in app.html and embed.js

 * Refactor Angular template <script> tag rendering to reduce
   duplication

 * Adapt buildext.py to render app.html and embed.js without going through Pyramid

 * Re-add Google Analytics tracking ID to app HTML template context

   For base.html.jinja2, the Google Analytics tracking ID is
   added by a renderer global in subscribers.py.

   Since app.html.jinja2 is rendered outside of this context,
   we need to pass in the tracking ID explicitly.

 * ga_create_options has been renamed to ga_cookie_domain
   and changed to be an unquoted string rather than a list
   of parameters since that is all we are using it for at the moment.

 * Explicitly disable Google Analytics tracking for the extension

   It was previously the case that when building the extension,
   the Google Analytics tracking ID was never included.

   I'm unsure whether this was intentional or not, so for the moment,
   explicitly pass in the tracking ID as None to make it more obvious
   that tracking is not being used.

73 of 73 new or added lines in 4 files covered. (100.0%)

2678 of 3810 relevant lines covered (70.29%)

0.7 hits per line

Relevant lines Covered
3810 RELEVANT LINES 2678 COVERED LINES
0.7 HITS PER LINE
Source Files on decouple_app_template_from_pyramid
Detailed source file information is not available for this build.

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
9898 decouple_app_template_from_pyramid Decouple sidebar HTML and embed JS template from webassets and Pyramid To enable building of the extension and client app without needing to set up the website, remove all dependencies of the sidebar HTML and embed JS rendering from Pyramid * E... push robertknight travis-ci pending completion  
9889 decouple_app_template_from_pyramid Decouple sidebar HTML and embed JS template from webassets and Pyramid To enable building of the extension and client app without needing to set up the website, remove all dependencies of the sidebar HTML and embed JS rendering from Pyramid * E... push robertknight travis-ci pending completion  
9887 decouple_app_template_from_pyramid Decouple sidebar HTML and embed JS template from webassets and Pyramid To enable building of the extension and client app without needing to set up the website, remove all dependencies of the sidebar HTML and embed JS rendering from Pyramid * E... push robertknight travis-ci pending completion  
9882 decouple_app_template_from_pyramid Decouple sidebar HTML and embed JS template from webassets and Pyramid To enable building of the extension and client app without needing to set up the website, remove all dependencies of the sidebar HTML and embed JS rendering from Pyramid * E... push robertknight travis-ci pending completion  
9877 decouple_app_template_from_pyramid Decouple sidebar HTML and embed JS template from webassets and Pyramid To enable building of the extension and client app without needing to set up the website, remove all dependencies of the sidebar HTML and embed JS rendering from Pyramid * E... push robertknight travis-ci pending completion  
9798 decouple_app_template_from_pyramid Set the base URL correctly to refer to '/' and not /app.html The client app currently expects the base URL to refer to the root URL for the Hypothesis web service and not the app.html page for the sidebar. In particular, in the extension this is ... push robertknight travis-ci pending completion  
9800 decouple_app_template_from_pyramid Set the base URL correctly to refer to '/' and not /app.html The client app currently expects the base URL to refer to the root URL for the Hypothesis web service and not the app.html page for the sidebar. In particular, in the extension this is ... push robertknight travis-ci pending completion  
9795 decouple_app_template_from_pyramid Explicitly disable Google Analytics tracking for the extension It was previously the case that when building the extension, the Google Analytics tracking ID was never included. I'm unsure whether this was intentional or not, so for the moment, e... push robertknight travis-ci pending completion  
9791 decouple_app_template_from_pyramid Small code cleanups * Sort imports according to codebase conventions * Use the term 'context' to refer to a template's context push robertknight travis-ci pending completion  
See All Builds (3935)