hyperscale-stack / security

99%

master: 98%

LAST BUILD ON BRANCH fix/audit2-oidc-client

branch: fix/audit2-oidc-client

CHANGE BRANCH

x

Reset

Sync Branches

• fix/audit2-oidc-client
• ci/real-db-stores
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/checkout-7
• dependabot/github_actions/actions/setup-go-7
• dependabot/github_actions/softprops/action-gh-release-3
• dependabot/go_modules/connectrpc.com/connect-1.21.0
• dependabot/go_modules/connectrpc.com/connect-1.21.1
• dependabot/go_modules/connectrpc.com/grpchealth-1.5.0
• dependabot/go_modules/github.com/alicebob/miniredis/v2-2.39.0
• dependabot/go_modules/github.com/alicebob/miniredis/v2-2.40.0
• dependabot/go_modules/github.com/chromedp/cdproto-0.157.9
• dependabot/go_modules/github.com/chromedp/cdproto-0.158.0
• dependabot/go_modules/github.com/chromedp/cdproto-0.158.4
• dependabot/go_modules/github.com/chromedp/chromedp-0.20.1
• dependabot/go_modules/github.com/chromedp/chromedp-0.21.0
• dependabot/go_modules/github.com/go-jose/go-jose/v4-4.1.5
• dependabot/go_modules/github.com/redis/go-redis/v9-9.19.0
• dependabot/go_modules/github.com/redis/go-redis/v9-9.20.0
• dependabot/go_modules/github.com/redis/go-redis/v9-9.20.1
• dependabot/go_modules/github.com/redis/go-redis/v9-9.21.0
• dependabot/go_modules/github.com/redis/go-redis/v9-9.22.0
• dependabot/go_modules/github.com/redis/go-redis/v9-9.23.0
• dependabot/go_modules/github.com/rs/zerolog-1.35.0
• dependabot/go_modules/github.com/rs/zerolog-1.35.1
• dependabot/go_modules/github.com/stretchr/testify-1.12.1
• dependabot/go_modules/github.com/zitadel/oidc/v3-3.51.16
• dependabot/go_modules/go.opentelemetry.io/otel-1.44.0
• dependabot/go_modules/go.opentelemetry.io/otel-1.45.0
• dependabot/go_modules/go.opentelemetry.io/otel-1.46.0
• dependabot/go_modules/go.opentelemetry.io/otel-1.47.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.44.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.45.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.46.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.47.0
• dependabot/go_modules/go.opentelemetry.io/otel/trace-1.44.0
• dependabot/go_modules/go.opentelemetry.io/otel/trace-1.45.0
• dependabot/go_modules/go.opentelemetry.io/otel/trace-1.46.0
• dependabot/go_modules/go.opentelemetry.io/otel/trace-1.47.0
• dependabot/go_modules/golang.org/x/crypto-0.45.0
• dependabot/go_modules/golang.org/x/crypto-0.46.0
• dependabot/go_modules/golang.org/x/crypto-0.47.0
• dependabot/go_modules/golang.org/x/crypto-0.48.0
• dependabot/go_modules/golang.org/x/crypto-0.49.0
• dependabot/go_modules/golang.org/x/crypto-0.50.0
• dependabot/go_modules/golang.org/x/crypto-0.51.0
• dependabot/go_modules/golang.org/x/crypto-0.52.0
• dependabot/go_modules/golang.org/x/crypto-0.53.0
• dependabot/go_modules/golang.org/x/crypto-0.54.0
• dependabot/go_modules/golang.org/x/crypto-0.55.0
• dependabot/go_modules/golang.org/x/crypto-0.56.0
• dependabot/go_modules/golang.org/x/crypto-0.57.0
• dependabot/go_modules/google.golang.org/grpc-1.81.1
• dependabot/go_modules/google.golang.org/grpc-1.82.0
• dependabot/go_modules/google.golang.org/grpc-1.82.1
• dependabot/go_modules/google.golang.org/grpc-1.83.0
• dependabot/go_modules/google.golang.org/grpc-1.83.1
• dependabot/go_modules/google.golang.org/grpc-1.83.2
• dependabot/go_modules/google.golang.org/grpc-1.84.0
• dependabot/go_modules/modernc.org/sqlite-1.51.0
• dependabot/go_modules/modernc.org/sqlite-1.52.0
• dependabot/go_modules/modernc.org/sqlite-1.53.0
• dependabot/go_modules/modernc.org/sqlite-1.54.0
• dependabot/go_modules/modernc.org/sqlite-1.56.0
• dependabot/go_modules/modernc.org/sqlite-1.57.0
• dependabot/go_modules/modernc.org/sqlite-1.58.0
• dependabot/go_modules/modernc.org/sqlite-1.60.1
• dependabot/go_modules/modernc.org/sqlite-1.61.0
• dependabot/go_modules/tools/osv-scanner/golang.org/x/vuln-1.9.0
• feat/audit2-attempt-limiter
• feature/63-oauth2-error-hook
• feature/64-oauth2-expires-in-clock
• feature/78-oauth2-refresh-rotation-profile
• feature/79-oauth2-pkce-syntax
• feature/80-oauth2-code-replay-revocation
• feature/81-oauth2-introspection-authz
• feature/82-oauth2-refresh-family-revocation
• feature/83-oauth2-oidc-extension-points
• feature/84-oidc-provider
• feature/85-oidc-client
• feature/86-oidc-interop
• feature/87-saml-sp
• feature/88-saml-adversarial-interop
• feature/94-oauth2-empty-client-secret
• feature/connectrpc
• feature/oauth2-server
• feature/refactoring
• fix/audit-ci-deps
• fix/audit-core-transport
• fix/audit-jwt
• fix/audit-oauth2-client-policy
• fix/audit-oauth2-endpoints
• fix/audit-oidc-client
• fix/audit-oidc-provider
• fix/audit-saml-sp
• fix/audit-session-password-basic
• fix/audit-sql-stores
• fix/audit2-core
• fix/audit2-jose
• fix/audit2-jwt
• fix/audit2-oauth2-front
• fix/audit2-oidc-provider
• fix/audit2-saml
• fix/audit2-stores
• fix/audit2-supply-chain
• master

Build # 39674750246

Build Type

Pull #125

github

Committed by euskadi31

Commit Message

docs(oidc/client): state the limits of Secret and the persistence break

The documentation of oidcclient.Secret overstated its reach and left
out the runtime break of persisted values:

- encoding/gob refuses any value holding a Secret, so a gob-encoded
  session holding an Identity fails to save; YAML writes a Secret
  empty; documents persisted before the upgrade no longer decode.
  MIGRATION gives the rows and a struct-of-strings recipe.
- fmt prints a Secret it reaches through an unexported field as an
  address, not REDACTED, and a reflection dumper that dereferences
  pointers without calling methods (go-spew with DisableMethods, as in
  testify's failure diffs) prints its value; embedding a Secret makes
  the whole struct print REDACTED.
- AuthRequest.URL carries every request parameter in clear, the
  id_token_hint included: its renderings drop the query, its JSON
  hand-off does not. The renderings test now covers the hint.

The DefaultCapacity memory figure also counts acr_values.

Audit: F-11, I-14, D-12.

Pull Request Pull Request #125: fix(oidc/client)!: close the security audit findings of the OIDC client

Coverage Stats

110 of 110 new or added lines in 14 files covered. (100.0%)

14886 of 15100 relevant lines covered (98.58%)

5336.48 hits per line