hyperscale-stack / security

97%

master: 98%

LAST BUILD ON BRANCH fix/audit-saml-sp

branch: fix/audit-saml-sp

CHANGE BRANCH

x

Reset

Sync Branches

• fix/audit-saml-sp
• ci/real-db-stores
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/checkout-7
• dependabot/github_actions/actions/setup-go-7
• dependabot/github_actions/softprops/action-gh-release-3
• dependabot/go_modules/connectrpc.com/connect-1.21.0
• dependabot/go_modules/connectrpc.com/connect-1.21.1
• dependabot/go_modules/connectrpc.com/grpchealth-1.5.0
• dependabot/go_modules/github.com/alicebob/miniredis/v2-2.39.0
• dependabot/go_modules/github.com/alicebob/miniredis/v2-2.40.0
• dependabot/go_modules/github.com/chromedp/cdproto-0.157.9
• dependabot/go_modules/github.com/chromedp/cdproto-0.158.0
• dependabot/go_modules/github.com/chromedp/cdproto-0.158.4
• dependabot/go_modules/github.com/chromedp/chromedp-0.20.1
• dependabot/go_modules/github.com/chromedp/chromedp-0.21.0
• dependabot/go_modules/github.com/go-jose/go-jose/v4-4.1.5
• dependabot/go_modules/github.com/redis/go-redis/v9-9.19.0
• dependabot/go_modules/github.com/redis/go-redis/v9-9.20.0
• dependabot/go_modules/github.com/redis/go-redis/v9-9.20.1
• dependabot/go_modules/github.com/redis/go-redis/v9-9.21.0
• dependabot/go_modules/github.com/redis/go-redis/v9-9.22.0
• dependabot/go_modules/github.com/redis/go-redis/v9-9.23.0
• dependabot/go_modules/github.com/rs/zerolog-1.35.0
• dependabot/go_modules/github.com/rs/zerolog-1.35.1
• dependabot/go_modules/github.com/stretchr/testify-1.12.1
• dependabot/go_modules/github.com/zitadel/oidc/v3-3.51.16
• dependabot/go_modules/go.opentelemetry.io/otel-1.44.0
• dependabot/go_modules/go.opentelemetry.io/otel-1.45.0
• dependabot/go_modules/go.opentelemetry.io/otel-1.46.0
• dependabot/go_modules/go.opentelemetry.io/otel-1.47.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.44.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.45.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.46.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.47.0
• dependabot/go_modules/go.opentelemetry.io/otel/trace-1.44.0
• dependabot/go_modules/go.opentelemetry.io/otel/trace-1.45.0
• dependabot/go_modules/go.opentelemetry.io/otel/trace-1.46.0
• dependabot/go_modules/go.opentelemetry.io/otel/trace-1.47.0
• dependabot/go_modules/golang.org/x/crypto-0.45.0
• dependabot/go_modules/golang.org/x/crypto-0.46.0
• dependabot/go_modules/golang.org/x/crypto-0.47.0
• dependabot/go_modules/golang.org/x/crypto-0.48.0
• dependabot/go_modules/golang.org/x/crypto-0.49.0
• dependabot/go_modules/golang.org/x/crypto-0.50.0
• dependabot/go_modules/golang.org/x/crypto-0.51.0
• dependabot/go_modules/golang.org/x/crypto-0.52.0
• dependabot/go_modules/golang.org/x/crypto-0.53.0
• dependabot/go_modules/golang.org/x/crypto-0.54.0
• dependabot/go_modules/golang.org/x/crypto-0.55.0
• dependabot/go_modules/golang.org/x/crypto-0.56.0
• dependabot/go_modules/golang.org/x/crypto-0.57.0
• dependabot/go_modules/google.golang.org/grpc-1.81.1
• dependabot/go_modules/google.golang.org/grpc-1.82.0
• dependabot/go_modules/google.golang.org/grpc-1.82.1
• dependabot/go_modules/google.golang.org/grpc-1.83.0
• dependabot/go_modules/google.golang.org/grpc-1.83.1
• dependabot/go_modules/google.golang.org/grpc-1.83.2
• dependabot/go_modules/google.golang.org/grpc-1.84.0
• dependabot/go_modules/modernc.org/sqlite-1.51.0
• dependabot/go_modules/modernc.org/sqlite-1.52.0
• dependabot/go_modules/modernc.org/sqlite-1.53.0
• dependabot/go_modules/modernc.org/sqlite-1.54.0
• dependabot/go_modules/modernc.org/sqlite-1.56.0
• dependabot/go_modules/modernc.org/sqlite-1.57.0
• dependabot/go_modules/modernc.org/sqlite-1.58.0
• dependabot/go_modules/modernc.org/sqlite-1.60.1
• dependabot/go_modules/modernc.org/sqlite-1.61.0
• dependabot/go_modules/tools/osv-scanner/golang.org/x/vuln-1.9.0
• feat/audit2-attempt-limiter
• feature/63-oauth2-error-hook
• feature/64-oauth2-expires-in-clock
• feature/78-oauth2-refresh-rotation-profile
• feature/79-oauth2-pkce-syntax
• feature/80-oauth2-code-replay-revocation
• feature/81-oauth2-introspection-authz
• feature/82-oauth2-refresh-family-revocation
• feature/83-oauth2-oidc-extension-points
• feature/84-oidc-provider
• feature/85-oidc-client
• feature/86-oidc-interop
• feature/87-saml-sp
• feature/88-saml-adversarial-interop
• feature/94-oauth2-empty-client-secret
• feature/connectrpc
• feature/oauth2-server
• feature/refactoring
• fix/audit-ci-deps
• fix/audit-core-transport
• fix/audit-jwt
• fix/audit-oauth2-client-policy
• fix/audit-oauth2-endpoints
• fix/audit-oidc-client
• fix/audit-oidc-provider
• fix/audit-session-password-basic
• fix/audit-sql-stores
• fix/audit2-core
• fix/audit2-jose
• fix/audit2-jwt
• fix/audit2-oauth2-front
• fix/audit2-oidc-client
• fix/audit2-oidc-provider
• fix/audit2-saml
• fix/audit2-stores
• fix/audit2-supply-chain
• master

Build # 38331738524

Build Type

Pull #116

github

Committed by euskadi31

Commit Message

docs(saml): complete the operator checklist; never modify the request

The operator checklist gains the SAML items the body text already
required: transaction keys from a secret store, the same on every
instance and distinct from the OIDC client's and the session's, with
the rotation order; least-privilege store access; rate limiting the ACS
per client as well as the login entry point; letting the ACS see the
host the browser used; ResponseOrigins or, without it, a short
TransactionTTL and no logged IdP redirect URLs.

The proxy snippet, the MIGRATION step and the godoc of ACSURL and
checkACSLocation no longer suggest assigning r.Host: a handler must not
modify the request it receives, so CompleteLogin gets a copy
(http.Request.Clone) whose Host comes from the trusted proxy's header,
and a multi-hop X-Forwarded-Host is read as the value that proxy wrote.

Audit: SAML-01, SAML-02, SAML-I9, STORE-02.

Pull Request Pull Request #116: fix(saml)!: close the security audit findings of the SAML Service Provider

Coverage Stats

518 of 533 new or added lines in 22 files covered. (97.19%)

1 existing line in 1 file now uncovered.

11752 of 12072 relevant lines covered (97.35%)

2710.9 hits per line