hyperscale-stack / businessid

94%

main: 94%

Pull #4

github

feat(testdata): real-world business-id corpus + integration tests

Add a hand-collected corpus of ~1300 real business identifiers (SIREN,
SIRET, VAT, national register numbers for BE/DE/ES/FR/IT/NL) sourced
from official registries, Wikipedia infoboxes and corporate legal
notices. The corpus lives under testdata/ and is consumed by four new
real-world tests (one per provider) plus a native-algorithm test under
providers/euid/. This gives the library a broader real-world safety
net than the current ~10 known-values-per-country coverage.

Layout:
  testdata/
    registers/<cc>-valide.txt   raw national register (source of truth)
    euid/<cc>-valide.txt        derived from registers, "<CC><REG>." prefix
    vat/<cc>-valide.txt         hand-collected VAT numbers (~25 per country)
    siret/fr-valide.txt         FR SIRETs (source of truth for FR)
    siren/fr-valide.txt         derived from SIRETs (siret[:9], dedupped)
    MANIFEST.md                 sources, counts, gaps

The derived files (euid/, siren/fr, registers/fr) are regenerated by
`go run ./hack/derive-corpus`, itself packaged as a separate module
under a Go workspace so its dev-tool dependencies stay isolated from
the library.

Countries covered (initial pass): BE (42), DE (100), ES (26), FR (113
SIRETs), IT (100), NL (81) for registers; ~25 VAT each. Remaining 21
EU countries: to be added later.

Data-quality notes:
- Numbers are collected first, tests run second, and failing entries
  are triaged one by one: real lib bug → fix; wrong transcription →
  remove. That process surfaced the ES CIF letter-check fix (separate
  commit) and revealed a batch of fabricated Wikipedia-sourced NL VAT
  numbers, replaced by btw-zoeken.nl-verified values.

Workspace / tooling:
- go.work + hack/derive-corpus/go.mod isolate the CLI.
- CI's go-version-file switched from go.mod to go.work.
- Makefile's `generate` target now loops over both modules like the
  other targets.

Tests: 2027 passing, 100 % statement c... (continued)

10 of 159 new or added lines in 3 files covered. (6.29%)

2407 of 2556 relevant lines covered (94.17%)

55.78 hits per line