hubotio / hubot

68%

master: 76%

LAST BUILD ON BRANCH programaticly-configured-hubot-js

branch: programaticly-configured-hubot-js

CHANGE BRANCH

x

Reset

• programaticly-configured-hubot-js
• 1355/load-supported-script-files-only
• 1363/engines-fix
• adapter_es2015_note
• add_datastore_clean
• document-custom-listener-text
• evolution/4/e2e-test
• evolution/4/test-es2015-export
• evolution/6/semantic-release
• fix-parse-help
• make-sure-npx-is-installed
• master
• no-more-next
• package-engines-update
• travis-deploy-semantic-release
• update-tested-nodes
• upgrade-npm-before-install
• v3

Build # 805

Build Type

push

travis-ci

Committed by technicalpickles

Commit Message

feat: Robot constructor to take an object of properties

Previously, Robot took positional arguments. This is fine for internal
use, but when programatically building, it looks weird because you have
a bunch of null and boolean values which don't make sense on their own.
It is bad for the reasons having multiple positional arguments is bad,
lack of readability.

Instead of positional arguments, this updates Robot to take an options
object, so the parameters are named and it is clear to a reader what
each does.

This continues to support the old positional arguments, but emits a
deprecation message with depd. Internal use of has been updated to use
the options object, and there probably aren't a ton of uses of Robot
directly in the wild (although there is definitely at least
hubot-test-helper). This support can be considered for removal during
the next breaking release.

This is part of https://github.com/hubotio/evolution/pull/3

Run Details

104 of 162 branches covered (64.2%)

Branch coverage included in aggregate %.

319 of 460 relevant lines covered (69.35%)

91.88 hits per line