honeybee / trellis

78%

master: 79%

LAST BUILD ON BRANCH 0.1.0

branch: 0.1.0

CHANGE BRANCH

x

Reset

• 0.1.0
• master
• entity-getvalue
• perftest
• immutability
• 0.1.1
• 0.1.3
• 0.1.2
• develop
• 0.1.4
• 0.1.5
• 0.1.6
• 0.1.7
• 0.1.8
• fix-custom_images_in_imagelistattribute
• 0.2.0
• 0.2.1
• fix-entity_list_test
• 0.2.2
• 0.2.3
• 0.2.4
• 0.2.5

Build # 186

Build Type

push

travis-ci

Committed by graste

Commit Message

remove default zeroing of time for DateAttribute

this leads to wrong interpretation of dates (off-by-one) as the time is
changed. The native format used still contains the time information to
provide the timezone information for consumers. A short format like
'yyyy-MM-dd+00:00' is not being used even though php likes it other
parties interpreting that value might not like it. One example are api
consumers that get that native value or even elasticsearch which wants to
see something like "yyyy-MM-ddT+00:00". That would be parsed as military
Tango time though by php. That's why we sent the time info. Meh.
Suggestions are welcome. Applications can reformat according to their
needs on their system boundaries.

Future improvement suggestion: internally store the timezone of the given
values to have them available later on. This helps in migrating stuff when
eg.g the timezone db changes.

refs #28

Run Details

4035 of 5183 relevant lines covered (77.85%)

56.71 hits per line