hluk / resultsdb

81%

develop: 81%

LAST BUILD ON BRANCH fix-param-type-check

branch: fix-param-type-check

CHANGE BRANCH

x

Reset

Sync Branches

• fix-param-type-check
• RHELWF-6471_configure_github_action
• add-image-expiration
• allow-submit-time-zone-suffix
• api-for-generic-results
• api_v3-docs
• avoid-updating-python-version
• black-flake8
• bump-base-image
• bump-flask-session
• custom-mod_wsgi-args
• custom_submit_time
• dependabot
• develop
• drop-api-v1
• drop-image-build
• drop-threads-override
• favicon
• fix-dependencies
• fix-disabling-fedmenu
• fix-group-result-count
• fix-init-session
• fix-main
• fix-main-2
• fix-mypy
• fix-outcome-case
• fix-outcome-type-check
• fix-tox-docker
• fix-tracing
• fix-typo
• ignore-coverage-generated-files
• ignore-non-password
• improve-401-message
• keep-stomp-connection-open
• merge-to-develop-tag-latest
• poetry
• postgres-update
• pre-commit
• precommit-autoupdate-monthly
• pydantic
• pydantic2
• python-3.11
• python-3.12-for-renovatebot
• python-3.13
• python-version
• refactor-complex-method
• refactor-outcome-validation
• remove-old-files
• renovate
• retry-messaging
• server-side-session
• slashes-in-testcases
• sonarqube-fixes
• support-konflux-mintmaker
• test-stomp-messaging
• trace-stomp-connection
• untangle-imports
• update
• update-black-formatting
• update-dependencies
• update-flask-sqlalchemy
• update-opentelemetry
• update-otel
• upgrade-python
• use-new-select
• uv
• uv-2

Build # 6716458675

Build Type

push

github

Committed by hluk

Commit Message

Fix checking parameter type

Workaround for a bug in flask-pydantic.

Avoids the following exception causing server to respond with HTTP 500:

    Traceback (most recent call last):
    File "/venv/lib64/python3.11/site-packages/flask_pydantic/core.py", line 197, in wrapper
        b = body_model(**body_params)
            ^^^^^^^^^^^^^^^^^^^^^^^^^
    TypeError: resultsdb.parsers.api_v3.BrewResultParams() argument after ** must be a mapping, not str

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
    File "/venv/lib64/python3.11/site-packages/flask/app.py", line 2190, in wsgi_app
        response = self.full_dispatch_request()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/venv/lib64/python3.11/site-packages/flask/app.py", line 1486, in full_dispatch_request
        rv = self.handle_user_exception(e)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/venv/lib64/python3.11/site-packages/flask/app.py", line 1484, in full_dispatch_request
        rv = self.dispatch_request()
            ^^^^^^^^^^^^^^^^^^^^^^^
    File "/venv/lib64/python3.11/site-packages/flask/app.py", line 1469, in dispatch_request
        return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/venv/lib64/python3.11/site-packages/flask_pyoidc/flask_pyoidc.py", line 463, in wrapper
        return view_func(*args, **kwargs)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/venv/lib64/python3.11/site-packages/flask_pydantic/core.py", line 204, in wrapper
        raise JsonBodyParsingError()
    flask_pydantic.exceptions.JsonBodyParsingError

Server will respond instead with HTTP 400 and the following JSON body:

    {
        "validation_error": {
            "body_params": [{
                "loc": ["__root__"],
                "msg": "value is not a valid dict",
                "type": "type_error.dict"
  ... (continued)

Run Details

1008 of 1239 relevant lines covered (81.36%)

0.81 hits per line