hluk / greenwave

87%

master: 87%

LAST BUILD ON BRANCH remoterule-consistency

branch: remoterule-consistency

CHANGE BRANCH

x

Reset

Sync Branches

• remoterule-consistency
• actions-build-image
• add-image-expiration
• add-sts-header-by-default
• allow-block-list
• avoid-head-requests
• avoid-heartbeat-timeouts
• avoid-passing-invalid-nvr-to-koji
• bump-base-image
• bump-postgres-image
• ci-build-docs
• ci-print-logs-on-failure
• clean-up-logs
• deduplicate-tests
• dependabot/pip/cryptography-37.0.2
• dependabot/pip/fedora-messaging-3.0.0
• dependabot/pip/fedora-messaging-3.0.2
• dependabot/pip/fedora-messaging-3.1.0
• dependabot/pip/flake8-5.0.2
• dependabot/pip/flask-2.1.3
• dependabot/pip/flask-2.2.2
• dependabot/pip/mock-5.0.1
• dependabot/pip/psycopg2-binary-2.9.4
• dependabot/pip/pymemcache-4.0.0
• dependabot/pip/pytest-7.1.3
• dependabot/pip/pytest-7.2.1
• dependabot/pip/pytest-cov-4.0.0
• dependabot/pip/requests-2.28.1
• dependabot/pip/setuptools-62.6.0
• dependabot/pip/setuptools-63.1.0
• dependabot/pip/setuptools-63.3.0
• dependabot/pip/setuptools-65.4.1
• dependabot/pip/setuptools-67.1.0
• dependabot/pip/sphinx-5.0.2
• dependabot/pip/sphinx-5.3.0
• dependabot/pip/sphinx-6.0.0
• dependabot/pip/sphinx-6.1.2
• dependabot/pip/sphinx-6.1.3
• dependabot/pip/sqlalchemy-1.4.39
• dependabot/pip/sqlalchemy-1.4.42
• dependabot/pip/sqlalchemy-1.4.44
• dependabot/pip/sqlalchemy-1.4.45
• dependabot/pip/sqlalchemy-1.4.46
• dependabot/pip/sqlalchemy-2.0.0
• dependabot/pip/sqlalchemy-2.0.1
• dependabot/pip/stomp-py-8.0.1
• dependabot/pip/stomp-py-8.1.0
• dependabot/pip/werkzeug-2.2.1
• dependabot/pip/wheel-0.38.4
• drop-old-item-requirement-property
• drop-requirements
• drop-sphinx-workaround
• fedora-minimal-base-image
• fix-access-rh-image-repo
• fix-ca-bundle-permission
• fix-chaining-labels
• fix-consumer-disconnects
• fix-decision-error-status
• fix-dependabot
• fix-dependabot-ci
• fix-dependabot-ci-2
• fix-docker-entry-point
• fix-docs
• fix-docs-build
• fix-docs-lang
• fix-hadolint
• fix-image-version
• fix-koji-source
• fix-listener-connection-timeout
• fix-listener-timeout
• fix-missing-dependency
• fix-multiple-remote-rule-contexts
• fix-mypy
• fix-parameter-type
• fix-podman-compose
• fix-readthedocs
• fix-semgrep
• fix-separate-timeout-for-remote-rule
• fix-sonarqube-warnings
• fix-sphinx
• fix-stomp-connection
• fix-subject-type-matching
• fix-tox
• fix-tox-python
• fix-using-multiple-remoterules
• fix-waive-all-scenarios
• fix/image/tag-name
• fixes
• github-actions-functional-tests
• image-labels
• improve-docs
• improve-error-handling
• improve-error-handling-for-brew
• include-waiver-id
• landing-page
• less-verbose-log
• master
• memcached-upgrade
• minimal-image
• minimize-image
• minimize-image-2
• missing-moksha-dependency
• multiple-subject-types
• mypy
• new-release
• pip-freeze
• poetry
• poetry-build-deps
• postgres-update
• pre-commit
• precommit-autoupdate-monthly
• python-3.11
• python-3.12-for-renovatebot
• python-3.13
• release
• remote-attribute-supports_remote_rule
• remote-rule-custom-sources
• remove-attribute-supports_remote_rule
• remove-unused-files
• renovate
• sanitize/image/tag/name
• satisfy-flake8-5
• secure-cookies
• semgrep
• statsd
• test-without-install
• thread-local-cache
• tox-poetry
• umb-image
• update-base-image
• update-dependencies
• update-dependencies-monthly
• update-dev-docs
• update-links
• update-opentelemetry
• update-readthedocs
• update-stomp.py
• update-waiverdb-command
• useful-metrics
• uv
• xmlrpc-retry

Build # 6081493712

Build Type

push

github

Committed by hluk

Commit Message

Make RemoteRule more consistent

Previously, a Greenwave policy with just a RemoteRule would cause
"Cannot find any applicable policies" 404 error if the remote policy
file does not contain a policy with the requested decision context. But
that was not the case if the Greenwave policy would contain at least one
PassingTestCaseRule.

New behavior is to pass the decision with "no tests are required"
instead of the 404 error.

**Decision responses** will always include policies (in
`applicable_policies`) that contain RemoteRule without checking if the
remote gating file contains any matching policy.

**Decision change messages** will still only be published if there are
any required tests.

Fixes https://pagure.io/greenwave/issue/668
JIRA: RHELWF-9620

Run Details

598 of 711 branches covered (0.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

18 existing lines in 1 file now uncovered.

1782 of 2036 relevant lines covered (87.52%)

0.88 hits per line