heroku / heroku-kafka-jsplugin

89%

master: 90%

LAST BUILD ON BRANCH avoid-in-for-flag-check

branch: avoid-in-for-flag-check

CHANGE BRANCH

x

Reset

• avoid-in-for-flag-check
• 2.0.3
• 2.0.4
• 2.0.5
• 2.0.6
• 2.2.2
• 2.2.3
• 2.3.0
• 2.6.0
• 2.7.0
• 2.8.0
• 2.8.1
• 2.9.0
• 2.9.1
• 2.9.2
• 2.9.3
• add-code-coverage
• add-codeowners
• add-prefix-support
• add-private-spaces-info-to-command-descriptions
• add_cek
• async-await
• before-and-after
• better-fail-messaging
• better-retention-time-description
• bump_version
• bump_version_again
• bump_version_for_addon_uuid
• bump_version_for_data_endpoints
• catch_400_in_consumer_group_create
• cli_command_for_rotating_client_credentials
• consumer-groups-create
• delete-consumer-groups
• dependabot/npm_and_yarn/eslint-4.18.2
• dependabot/npm_and_yarn/extend-3.0.2
• dependabot/npm_and_yarn/handlebars-4.5.3
• dependabot/npm_and_yarn/ini-1.3.7
• dependabot/npm_and_yarn/is-my-json-valid-2.20.0
• dependabot/npm_and_yarn/sshpk-1.16.1
• dependabot/npm_and_yarn/stringstream-0.0.6
• dependabot/npm_and_yarn/tough-cookie-2.3.4
• dependabot/npm_and_yarn/y18n-3.2.2
• do-not-count-__consumer_offsets-in-kafka-info
• drop-duplicate-add-on-name
• drop-maybe-useless-.coveralls.yaml
• drop-pointless-RF-check
• drop-useless-debug-logging
• fix-consumer-group-creation-message
• fix-info
• fix-interval-formatting
• fix-readme-markdown
• fix-topic-count-better
• fix-topics-compaction-retention
• fix-trigger-failure-message
• fix-v6-compatibility-for-real-this-time
• fix_data_size
• fixup
• handle_prefixed_topic_names_when_fetching_config
• improve-release-documentation
• info-prefix
• kafka-topic-prefix-more-explicit
• kafka_wait_bug
• link-to-centralized-plugin-publishing-docs
• lint-better
• main
• make-creds--reset-flag-required
• master
• minor-cleanup
• mix_compaction_and_retention_in_topic_info
• more-robust-config-var-handling-for-write-and-tail
• no-more-default-partitions
• no_clients_no_problems
• optional-kafka
• preauth-everywhere
• prefix-command
• private-not-shield
• private_can_write_tail
• remove-jmx
• remove-recommendation
• revert-122-use_addon_id_instead_of_name
• show-partition-replica-usage-and-limit
• show_max_topics_limit_in_kafka_info
• show_topic_limits
• snappyjs
• standard-10
• test-more
• to-prefix-or-not
• topics-info-proper
• unhide-cg
• update-default-branch
• update_docs
• update_help_for_mtls
• use-cli.color
• use-np
• use_addon_id_instead_of_name
• use_data_apis_instead_of_client
• v2.0.3
• v2.0.4
• v2.0.5
• v2.0.6
• v2.1.0
• v2.10.0
• v2.10.1
• v2.11.0
• v2.2.1
• v2.2.2
• v2.2.3
• v2.3.0
• v2.4.0
• v2.5.0
• v2.6.0
• v2.7.0
• v2.8.0
• v2.8.1
• v2.9.0
• v2.9.1
• v2.9.10
• v2.9.11
• v2.9.12
• v2.9.13
• v2.9.14
• v2.9.15
• v2.9.16
• v2.9.17
• v2.9.2
• v2.9.4
• v2.9.6
• v2.9.7
• v2.9.9
• v6-cmd
• v6-compatibility
• warn_users_about_upgrades_more

Build # 561

Build Type

push

travis-ci

Committed by uhoh-itsmaciek

Commit Message

Avoid using the 'in' operator to check for presence of flags

CLI v5 only sends the flags the user passed in on the flags object,
but CLI v6 sends in all defined flags, with values of undefined for
ones not explicitly set. Since `'a' in { a: undefined }` is true,
change these to use an explicit check against `undefined` instead.

Run Details

171 of 219 branches covered (78.08%)

534 of 602 relevant lines covered (88.7%)

5.23 hits per line