haya14busa / go-vimlparser

84%

master: 83%

LAST BUILD ON BRANCH performance-export

branch: performance-export

CHANGE BRANCH

x

Reset

• performance-export
• ast-node-type
• ast-walk
• avoid-reflect
• ci
• ci-run-generate
• fix-lambda-dict
• fix-minlen
• fix-parse-cmd
• fix-wincmd
• go-closure
• go-fix-incorrect-e477
• go-update-builtin-commands
• go-vimlparser-lambda
• improve-ci
• improve-error-msg
• json-arg
• master
• minor-compiler-improvement
• paren-expr
• parse-syntax-cmd
• performance
• readme
• reviewdog
• sum-type

Build # 101

Build Type

push

travis-ci

Committed by haya14busa

Commit Message

reduce slice allocation when NODE_DICT type conversion

Before:
         .          .    375:
         .          .    376:   case NODE_DICT:
         .          .    377:           var kvs []ast.KeyValue
         .          .    378:           for _, nn := range n.value.([]interface{}) {
         .          .    379:                   kv := nn.([]interface{})
         .        3MB    380:                   k := newAstNode(kv[0].(*VimNode))
         .     2.50MB    381:                   v := newAstNode(kv[1].(*VimNode))
       5MB        5MB    382:                   kvs = append(kvs, ast.KeyValue{Key: k, Value: v})
         .          .    383:           }
         .          .    384:           return &ast.Dict{
         .          .    385:                   Lcurlybrace: pos,
         .          .    386:                   Entries:     kvs,
         .          .    387:           }
         .          .    388:

After:
         .          .    375:
         .          .    376:   case NODE_DICT:
         .          .    377:           entries := n.value.([]interface{})
       2MB        2MB    378:           kvs := make([]ast.KeyValue, 0, len(entries))
         .          .    379:           for _, nn := range entries {
         .          .    380:                   kv := nn.([]interface{})
         .     3.50MB    381:                   k := newAstNode(kv[0].(*VimNode))
         .     3.50MB    382:                   v := newAstNode(kv[1].(*VimNode))
         .          .    383:                   kvs = append(kvs, ast.KeyValue{Key: k, Value: v})
         .          .    384:           }
         .          .    385:           return &ast.Dict{
         .          .    386:                   Lcurlybrace: pos,
       1MB        1MB    387:                   Entries:     kvs,
         .          .    388:           }

Run Details

3544 of 4231 relevant lines covered (83.76%)

29072.61 hits per line